0038140: MobileServerController.readCentralServer is not using bind-parameters

Description

This code should use bind-parameter for mobileServerKey

      OBQuery<MobileServerDefinition> servers = OBDal.getInstance().createQuery(
          MobileServerDefinition.class,
          "client.id=:clientId and " + MobileServerDefinition.PROPERTY_ACTIVE + "=true and "
              + MobileServerDefinition.PROPERTY_MOBILESERVERKEY + "!='" + mobileServerKey
              + "' and " + MobileServerDefinition.PROPERTY_SERVERTYPE + "='"
              + MobileServerUtils.MAIN_SERVER + "' order by "
              + MobileServerDefinition.PROPERTY_PRIORITY);

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0038136

acknowledged

Triage Platform Base

Openbravo ERP

Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0103294) hgbot (developer) 2018-03-16 08:18	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 618f62b41a43523988ed11ad64d5d54615e7fafb Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Mar 14 17:50:19 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/618f62b41a43523988ed11ad64d5d54615e7fafb [^] Fixed bug 38140 use bind-parameters in MobileServerController.readCentralServer --- M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java ---

Issue History
Date Modified	Username	Field	Change
2018-03-14 13:49	shuehner	New Issue
2018-03-14 13:49	shuehner	Assigned To	=> Retail
2018-03-14 13:49	shuehner	Triggers an Emergency Pack	=> No
2018-03-14 13:49	shuehner	Relationship added	blocks 0038136
2018-03-14 16:34	shuehner	Assigned To	Retail => Sandrahuguet
2018-03-14 17:50	Sandrahuguet	Status	new => scheduled
2018-03-16 08:18	hgbot	Checkin
2018-03-16 08:18	hgbot	Note Added: 0103294
2018-03-16 08:18	hgbot	Status	scheduled => resolved
2018-03-16 08:18	hgbot	Resolution	open => fixed
2018-03-16 08:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/618f62b41a43523988ed11ad64d5d54615e7fafb [^]
2018-03-16 08:31	Sandrahuguet	Review Assigned To	=> marvintm
2018-03-19 09:31	marvintm	Status	resolved => closed
2018-03-19 09:31	marvintm	Fixed in Version	=> RR18Q2