Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038140Retail ModulesWeb POSpublic2018-03-14 13:492018-03-19 09:31
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038140: MobileServerController.readCentralServer is not using bind-parameters
DescriptionThis code should use bind-parameter for mobileServerKey

      OBQuery<MobileServerDefinition> servers = OBDal.getInstance().createQuery(
          MobileServerDefinition.class,
          "client.id=:clientId and " + MobileServerDefinition.PROPERTY_ACTIVE + "=true and "
              + MobileServerDefinition.PROPERTY_MOBILESERVERKEY + "!='" + mobileServerKey
              + "' and " + MobileServerDefinition.PROPERTY_SERVERTYPE + "='"
              + MobileServerUtils.MAIN_SERVER + "' order by "
              + MobileServerDefinition.PROPERTY_PRIORITY);

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-14 13:49shuehnerNew Issue
2018-03-14 13:49shuehnerAssigned To => Retail
2018-03-14 13:49shuehnerTriggers an Emergency Pack => No
2018-03-14 13:49shuehnerRelationship addedblocks 0038136
2018-03-14 16:34shuehnerAssigned ToRetail => Sandrahuguet
2018-03-14 17:50SandrahuguetStatusnew => scheduled
2018-03-16 08:18hgbotCheckin
2018-03-16 08:18hgbotNote Added: 0103294
2018-03-16 08:18hgbotStatusscheduled => resolved
2018-03-16 08:18hgbotResolutionopen => fixed
2018-03-16 08:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/618f62b41a43523988ed11ad64d5d54615e7fafb [^]
2018-03-16 08:31SandrahuguetReview Assigned To => marvintm
2018-03-19 09:31marvintmStatusresolved => closed
2018-03-19 09:31marvintmFixed in Version => RR18Q2

Notes
(0103294)
hgbot   
2018-03-16 08:18   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 618f62b41a43523988ed11ad64d5d54615e7fafb
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Mar 14 17:50:19 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/618f62b41a43523988ed11ad64d5d54615e7fafb [^]

Fixed bug 38140 use bind-parameters in MobileServerController.readCentralServer

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---