0038133: AddPack.java has query which is not using bind-parameters

Description

That query is not using bind-parameters but embedding data values directly into SQL text:

    final OBQuery<OrderLine> qSamePackLines = OBDal
        .getInstance()
        .createQuery(
            OrderLine.class,
            " as e where e.salesOrder='"
                + order.getId()
                + "' and exists(select 1 from OrderLineOffer offer where e = offer.salesOrderLine and offer.priceAdjustment.id = '"
                + pack.getId() + "')");

Steps To Reproduce

Proposed Solution

Use bind-parameters as usual.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0038136

acknowledged

Triage Platform Base

Openbravo ERP

Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0103295) hgbot (developer) 2018-03-16 08:19	Repository: erp/pmods/org.openbravo.retail.discounts Changeset: 59ad14d4c841788b7bbe681e3750fcbbfe04b63d Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Mar 14 17:10:34 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59ad14d4c841788b7bbe681e3750fcbbfe04b63d [^] fixed issue 38133 use bind-parameters in addPack query --- M src/org/openbravo/retail/discounts/AddPack.java ---

Issue History
Date Modified	Username	Field	Change
2018-03-14 11:56	shuehner	New Issue
2018-03-14 11:56	shuehner	Assigned To	=> Retail
2018-03-14 11:56	shuehner	OBNetwork customer	=> No
2018-03-14 11:56	shuehner	Triggers an Emergency Pack	=> No
2018-03-14 13:03	shuehner	Relationship added	blocks 0038136
2018-03-14 16:35	shuehner	Assigned To	Retail => Sandrahuguet
2018-03-14 17:25	Sandrahuguet	Status	new => scheduled
2018-03-16 08:19	hgbot	Checkin
2018-03-16 08:19	hgbot	Note Added: 0103295
2018-03-16 08:19	hgbot	Status	scheduled => resolved
2018-03-16 08:19	hgbot	Resolution	open => fixed
2018-03-16 08:19	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59ad14d4c841788b7bbe681e3750fcbbfe04b63d [^]
2018-03-16 08:28	Sandrahuguet	Review Assigned To	=> marvintm
2018-03-19 09:36	marvintm	Status	resolved => closed
2018-03-19 09:36	marvintm	Fixed in Version	=> RR18Q2