Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038133Retail ModulesWeb POSpublic2018-03-14 11:562018-03-19 09:36
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038133: AddPack.java has query which is not using bind-parameters
DescriptionThat query is not using bind-parameters but embedding data values directly into SQL text:

    final OBQuery<OrderLine> qSamePackLines = OBDal
        .getInstance()
        .createQuery(
            OrderLine.class,
            " as e where e.salesOrder='"
                + order.getId()
                + "' and exists(select 1 from OrderLineOffer offer where e = offer.salesOrderLine and offer.priceAdjustment.id = '"
                + pack.getId() + "')");

Steps To Reproduce-
Proposed SolutionUse bind-parameters as usual.
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-14 11:56shuehnerNew Issue
2018-03-14 11:56shuehnerAssigned To => Retail
2018-03-14 11:56shuehnerOBNetwork customer => No
2018-03-14 11:56shuehnerTriggers an Emergency Pack => No
2018-03-14 13:03shuehnerRelationship addedblocks 0038136
2018-03-14 16:35shuehnerAssigned ToRetail => Sandrahuguet
2018-03-14 17:25SandrahuguetStatusnew => scheduled
2018-03-16 08:19hgbotCheckin
2018-03-16 08:19hgbotNote Added: 0103295
2018-03-16 08:19hgbotStatusscheduled => resolved
2018-03-16 08:19hgbotResolutionopen => fixed
2018-03-16 08:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59ad14d4c841788b7bbe681e3750fcbbfe04b63d [^]
2018-03-16 08:28SandrahuguetReview Assigned To => marvintm
2018-03-19 09:36marvintmStatusresolved => closed
2018-03-19 09:36marvintmFixed in Version => RR18Q2

Notes
(0103295)
hgbot   
2018-03-16 08:19   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 59ad14d4c841788b7bbe681e3750fcbbfe04b63d
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Mar 14 17:10:34 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59ad14d4c841788b7bbe681e3750fcbbfe04b63d [^]

fixed issue 38133 use bind-parameters in addPack query

---
M src/org/openbravo/retail/discounts/AddPack.java
---