Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038068 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | always | 2018-03-07 13:52 | 2018-03-12 13:17 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR18Q1.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ab75739af689 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR18Q1.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2016-11-08 | |||||||
| Regression introduced in release | 3.0PR17Q1 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/7acec5407733 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038068: incorrect view cache in browse for windows with server display logic | |||||||
| Description | View definition for windows that have at least a field with server side display logic are not correctly cached in browser if there is no preference configuring that field. The affected windows are: select distinct w.name from ad_field f, ad_tab t, ad_window w where displaylogic_server is not null and f.ad_Tab_id = t.ad_tab_id and w.ad_window_id = t.ad_window_id order by 1; name ----------------------------- Create Purchase Order Lines Goods Movements Goods Receipt Goods Shipment Manage Requisitions Purchase Invoice Purchase Order Referenced Inventory Requisition Return from Customer Return Material Receipt Return to Vendor Return to Vendor Shipment Sales Invoice Sales Order Sales Quotation (16 rows) | |||||||
| Steps To Reproduce | 1. Log in as Openbravo 2. Open dev tools to check requests 3. Open Sales Order window -> OK: a request to View?viewId=_143 is triggered with response code 200 (success) 4. Close Sales Order window and reopen it in the same session -> OK: no request is perfomed 5. Close session and log in again with Openbravo user in the same browser 6. Open Sales Order window -> GOT: a request to View?viewId=_143 is triggered with response code 200 EXPECTED: a request to View?viewId=_143 with response code 304 (not modified) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103078) hgbot (developer) 2018-03-08 10:18 |
Repository: erp/backports/3.0PR18Q1.1 Changeset: ab75739af6898d55fabef9f161222136c66e69d8 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed Mar 07 14:26:09 2018 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/ab75739af6898d55fabef9f161222136c66e69d8 [^] fixed bug 38068: no view cache in browser for windows with server display logic Window having at least a field with server side display logic were not cached in browser if there was no preference configuring that display logic. The problem was cuased by an incorrect eTag calculation that if not preference was set a date in future was set including current hour. The fix: * Simplifies eTag calculation for this case: if no preference defined, no need to add any date. * Uses for StringBuilder for String concatenation to slightly improve performance --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java --- |
|
(0103157) caristu (developer) 2018-03-12 13:17 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-03-07 14:18 | alostale | Type | defect => backport |
| 2018-03-07 14:18 | alostale | Target Version | => 3.0PR18Q1.1 |
| 2018-03-08 10:18 | hgbot | Checkin | |
| 2018-03-08 10:18 | hgbot | Note Added: 0103078 | |
| 2018-03-08 10:18 | hgbot | Status | scheduled => resolved |
| 2018-03-08 10:18 | hgbot | Resolution | open => fixed |
| 2018-03-08 10:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/ab75739af6898d55fabef9f161222136c66e69d8 [^] |
| 2018-03-12 13:17 | caristu | Note Added: 0103157 | |
| 2018-03-12 13:17 | caristu | Status | resolved => closed |
| 2018-03-12 13:17 | caristu | Fixed in Version | => 3.0PR18Q1.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |