Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038068Openbravo ERPA. Platformpublic2018-03-07 13:522018-03-12 13:17
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q1.1Fixed in Version3.0PR18Q1.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-11-08
Regression introduced in release3.0PR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/7acec5407733 [^]
Triggers an Emergency PackNo
Summary0038068: incorrect view cache in browse for windows with server display logic
DescriptionView definition for windows that have at least a field with server side display logic are not correctly cached in browser if there is no preference configuring that field.

The affected windows are:

select distinct w.name from ad_field f, ad_tab t, ad_window w where displaylogic_server is not null and f.ad_Tab_id = t.ad_tab_id and w.ad_window_id = t.ad_window_id order by 1;
            name
-----------------------------
 Create Purchase Order Lines
 Goods Movements
 Goods Receipt
 Goods Shipment
 Manage Requisitions
 Purchase Invoice
 Purchase Order
 Referenced Inventory
 Requisition
 Return from Customer
 Return Material Receipt
 Return to Vendor
 Return to Vendor Shipment
 Sales Invoice
 Sales Order
 Sales Quotation
(16 rows)
Steps To Reproduce1. Log in as Openbravo
2. Open dev tools to check requests
3. Open Sales Order window
   -> OK: a request to View?viewId=_143 is triggered with response code 200 (success)
4. Close Sales Order window and reopen it in the same session
   -> OK: no request is perfomed
5. Close session and log in again with Openbravo user in the same browser
6. Open Sales Order window
   -> GOT: a request to View?viewId=_143 is triggered with response code 200
      EXPECTED: a request to View?viewId=_143 with response code 304 (not modified)

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038066 closed alostale incorrect view cache in browser for windows with server display logic 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-07 14:18alostaleTypedefect => backport
2018-03-07 14:18alostaleTarget Version => 3.0PR18Q1.1
2018-03-08 10:18hgbotCheckin
2018-03-08 10:18hgbotNote Added: 0103078
2018-03-08 10:18hgbotStatusscheduled => resolved
2018-03-08 10:18hgbotResolutionopen => fixed
2018-03-08 10:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/ab75739af6898d55fabef9f161222136c66e69d8 [^]
2018-03-12 13:17caristuNote Added: 0103157
2018-03-12 13:17caristuStatusresolved => closed
2018-03-12 13:17caristuFixed in Version => 3.0PR18Q1.1

Notes
(0103078)
hgbot   
2018-03-08 10:18   
Repository: erp/backports/3.0PR18Q1.1
Changeset: ab75739af6898d55fabef9f161222136c66e69d8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 07 14:26:09 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/ab75739af6898d55fabef9f161222136c66e69d8 [^]

fixed bug 38068: no view cache in browser for windows with server display logic

  Window having at least a field with server side display logic were not cached
  in browser if there was no preference configuring that display logic.

  The problem was cuased by an incorrect eTag calculation that if not preference
  was set a date in future was set including current hour.

  The fix:
   * Simplifies eTag calculation for this case: if no preference defined, no need
     to add any date.
   * Uses for StringBuilder for String concatenation to slightly improve performance

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
---
(0103157)
caristu   
2018-03-12 13:17   
Code reviewed + tested OK.