Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036727
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] SEPA Framework and Utilitiesmajoralways2017-08-28 12:132017-09-05 16:22
ReportermaiteView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisioneda16578eb38
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket47979
OBNetwork customerOBPS
Regression introduced in release
Summary

0036727: <PmtInfId> needs to be unique according with SEPA rules

DescriptionAt the moment, we are setting "PmtInfId" value as "Remittance Documentno + DueDate", which could not be unique depending on remittance elements
Steps To Reproduce0. Install last version of "SEPA Credit Transfer Customer-to-Bank" and apply dataset
1. Create Purchase Invoice for any org and bp, today's date and payment terms=immediate. Add any line and process
2. Create another Purchase invoice for same org and bp, today's date and payment terms=immediate. Add any line and process
3. Create new remittance header setting Expected date > today's date
4. Run "Select orders or invoices" process and select 2 previous invoices (you could need to check "Show payments for alternative payment methods")
5. Process remittance selecting "no grouping" option
6. Run "Create remittance file" process and realize that file contains 2 <PmtInfId> with same value (ie, <PmtInfId>1000037-2017-08-28</PmtInfId>)
Proposed Solutionto add a "counter" at the end of <PmtInfId> value to ensure that it is unique (ie, <PmtInfId>1000037-2017-08-28-01</PmtInfId>, <PmtInfId>1000037-2017-08-28-02</PmtInfId>)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0098825)
AtulOpenbravo (viewer)
2017-09-05 11:15
edited on: 2017-09-05 11:25

 - Install last version of "SEPA Credit Transfer Customer-to-Bank" and apply dataset.
- Create Purchase Invoice for any org and bp, today's date and invoice terms=immediate. Add any line and process.
- Create another Purchase invoice for same org and bp, today's date and invoice terms=immediate. Add any line and process.
- Add SEPA Credit Transfer Customer-to-Bank payment method to financial account for eg: Cuenta de Banco and also set IBAN no in financial account for eg:-ESxxxxxxxxxxxxxxxxxxxxxx
- In remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)" parameters
  - set BIC_SWIFT_MANDATORY = No
  - set GENERATE_BUSINESSPARTNER_IBAN = Yes
- Create new remittance header setting Expected date > today's date, select remittance type for SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)
- Run "Select orders or invoices" process and select 2 previous invoices (you could need to check "Show payments for alternative payment methods")
- Process remittance selecting "no grouping" option.
- Run "Create remittance file" process and realize that file contains 2 <PmtInfId> with different value (ie, <PmtInfId>1000000-2017-09-05-20</PmtInfId> and <PmtInfId>1000000-2017-09-05-10</PmtInfId>)
(0098837)
hgbot (developer)
2017-09-05 16:19

 Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: eda16578eb38dab5daca0d74fb67f60384e20781
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Sep 05 14:39:01 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/eda16578eb38dab5daca0d74fb67f60384e20781 [^]

Fixes issue 36727: <PmtInfId> needs to be unique according with SEPA rules

Add line no as counter to payment information identifier string to
distinguish the records.

---
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
---
(0098838)
hgbot (developer)
2017-09-05 16:19

 Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: 7fe1ac55f9908994439df2420d7f1b7ac2ac8823
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 05 14:40:53 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/7fe1ac55f9908994439df2420d7f1b7ac2ac8823 [^]

Related to issue 36727: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0098839)
aferraz (viewer)
2017-09-05 16:22

 Code review + Testing OK

- Issue History
Date Modified Username Field Change
2017-08-28 12:13 maite New Issue
2017-08-28 12:13 maite Assigned To => Triage Finance
2017-08-28 12:13 maite Resolution time => 1505685600
2017-08-28 12:13 maite Support ticket => 47979
2017-08-28 12:13 maite OBNetwork customer => Yes
2017-08-28 12:13 maite Issue Monitored: networkb
2017-09-01 12:46 aferraz Assigned To Triage Finance => AtulOpenbravo
2017-09-05 11:15 AtulOpenbravo Note Added: 0098825
2017-09-05 11:16 AtulOpenbravo Status new => scheduled
2017-09-05 11:25 AtulOpenbravo Note Edited: 0098825 View Revisions
2017-09-05 11:25 AtulOpenbravo Note Edited: 0098825 View Revisions
2017-09-05 15:02 aferraz Steps to Reproduce Updated View Revisions
2017-09-05 16:19 hgbot Checkin
2017-09-05 16:19 hgbot Note Added: 0098837
2017-09-05 16:19 hgbot Status scheduled => resolved
2017-09-05 16:19 hgbot Resolution open => fixed
2017-09-05 16:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/eda16578eb38dab5daca0d74fb67f60384e20781 [^]
2017-09-05 16:19 hgbot Checkin
2017-09-05 16:19 hgbot Note Added: 0098838
2017-09-05 16:22 aferraz Review Assigned To => aferraz
2017-09-05 16:22 aferraz Note Added: 0098839
2017-09-05 16:22 aferraz Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker