Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036727ModulesSEPA Framework and Utilitiespublic2017-08-28 12:132017-09-05 16:22
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket47979
OBNetwork customerOBPS
Regression introduced in release
Summary0036727: <PmtInfId> needs to be unique according with SEPA rules
DescriptionAt the moment, we are setting "PmtInfId" value as "Remittance Documentno + DueDate", which could not be unique depending on remittance elements
Steps To Reproduce0. Install last version of "SEPA Credit Transfer Customer-to-Bank" and apply dataset
1. Create Purchase Invoice for any org and bp, today's date and payment terms=immediate. Add any line and process
2. Create another Purchase invoice for same org and bp, today's date and payment terms=immediate. Add any line and process
3. Create new remittance header setting Expected date > today's date
4. Run "Select orders or invoices" process and select 2 previous invoices (you could need to check "Show payments for alternative payment methods")
5. Process remittance selecting "no grouping" option
6. Run "Create remittance file" process and realize that file contains 2 <PmtInfId> with same value (ie, <PmtInfId>1000037-2017-08-28</PmtInfId>)
Proposed Solutionto add a "counter" at the end of <PmtInfId> value to ensure that it is unique (ie, <PmtInfId>1000037-2017-08-28-01</PmtInfId>, <PmtInfId>1000037-2017-08-28-02</PmtInfId>)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-28 12:13maiteNew Issue
2017-08-28 12:13maiteAssigned To => Triage Finance
2017-08-28 12:13maiteResolution time => 1505685600
2017-08-28 12:13maiteSupport ticket => 47979
2017-08-28 12:13maiteOBNetwork customer => Yes
2017-08-28 12:13maiteIssue Monitored: networkb
2017-09-01 12:46aferrazAssigned ToTriage Finance => AtulOpenbravo
2017-09-05 11:15AtulOpenbravoNote Added: 0098825
2017-09-05 11:16AtulOpenbravoStatusnew => scheduled
2017-09-05 11:25AtulOpenbravoNote Edited: 0098825bug_revision_view_page.php?bugnote_id=0098825#r15804
2017-09-05 11:25AtulOpenbravoNote Edited: 0098825bug_revision_view_page.php?bugnote_id=0098825#r15805
2017-09-05 15:02aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15815#r15815
2017-09-05 16:19hgbotCheckin
2017-09-05 16:19hgbotNote Added: 0098837
2017-09-05 16:19hgbotStatusscheduled => resolved
2017-09-05 16:19hgbotResolutionopen => fixed
2017-09-05 16:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/eda16578eb38dab5daca0d74fb67f60384e20781 [^]
2017-09-05 16:19hgbotCheckin
2017-09-05 16:19hgbotNote Added: 0098838
2017-09-05 16:22aferrazReview Assigned To => aferraz
2017-09-05 16:22aferrazNote Added: 0098839
2017-09-05 16:22aferrazStatusresolved => closed

Notes
(0098825)
AtulOpenbravo   
2017-09-05 11:15   
(edited on: 2017-09-05 11:25)
- Install last version of "SEPA Credit Transfer Customer-to-Bank" and apply dataset.
- Create Purchase Invoice for any org and bp, today's date and invoice terms=immediate. Add any line and process.
- Create another Purchase invoice for same org and bp, today's date and invoice terms=immediate. Add any line and process.
- Add SEPA Credit Transfer Customer-to-Bank payment method to financial account for eg: Cuenta de Banco and also set IBAN no in financial account for eg:-ESxxxxxxxxxxxxxxxxxxxxxx
- In remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)" parameters
  - set BIC_SWIFT_MANDATORY = No
  - set GENERATE_BUSINESSPARTNER_IBAN = Yes
- Create new remittance header setting Expected date > today's date, select remittance type for SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)
- Run "Select orders or invoices" process and select 2 previous invoices (you could need to check "Show payments for alternative payment methods")
- Process remittance selecting "no grouping" option.
- Run "Create remittance file" process and realize that file contains 2 <PmtInfId> with different value (ie, <PmtInfId>1000000-2017-09-05-20</PmtInfId> and <PmtInfId>1000000-2017-09-05-10</PmtInfId>)
(0098837)
hgbot   
2017-09-05 16:19   
Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: eda16578eb38dab5daca0d74fb67f60384e20781
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Sep 05 14:39:01 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/eda16578eb38dab5daca0d74fb67f60384e20781 [^]

Fixes issue 36727: <PmtInfId> needs to be unique according with SEPA rules

Add line no as counter to payment information identifier string to
distinguish the records.

---
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
---
(0098838)
hgbot   
2017-09-05 16:19   
Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: 7fe1ac55f9908994439df2420d7f1b7ac2ac8823
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 05 14:40:53 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/7fe1ac55f9908994439df2420d7f1b7ac2ac8823 [^]

Related to issue 36727: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0098839)
aferraz   
2017-09-05 16:22   
Code review + Testing OK