Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036724 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2017-08-25 18:05 | 2017-09-21 16:49 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | c827d58b4155 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036724: CSSMinimizer does not work well with "quotes" property | |||||||
| Description | CSSMinimizer does not work well with "quotes" property This property accepts several arguments: https://www.w3schools.com/cssref/pr_gen_quotes.asp [^] CSSMinimizer has a feature to remove duplicated parameters if exist. This works ok with most of the properties, e.g. "margin", where "100% 100%" or "100% 100% 100% 100%" can be simplified to just "100%", but in the case of "quotes", having only one parameter does not assume that the remaining ones have the same value, so this simplification cannot be performed, and all the parameters should be declared in a explicit way (otherwise, the missing one will adopt the default value). | |||||||
| Steps To Reproduce | Include in any CSS loaded within the application. quotes: '\0027' '\0027'; With the modules NOT in development, notice that the compressed CSS has only "quotes: '\0027';". (With this simplification the CSS draws " instead of ') | |||||||
| Proposed Solution | Avoid the function "simplifyParameters" of CSSMinimizer be executed if the property is "quotes" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0098663) hgbot (developer) 2017-08-25 18:09 |
Repository: erp/devel/pi Changeset: c827d58b415539a7e65eb96e26ab781a65cf0294 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Fri Aug 25 18:08:28 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c827d58b415539a7e65eb96e26ab781a65cf0294 [^] Fixed issue 36724: 'quotes' css property now is properly minimized --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java --- |
|
(0098767) caristu (developer) 2017-09-01 08:53 |
Code reviewed + tested OK. |
|
(0098815) caristu (developer) 2017-09-04 16:02 |
Created a pull request[1] in owner's library. [1] https://github.com/barryvan/CSSMin/pull/22 [^] |
|
(0099333) hudsonbot (developer) 2017-09-21 16:49 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-08-25 18:05 | dbaz | New Issue | |
| 2017-08-25 18:05 | dbaz | Assigned To | => dbaz |
| 2017-08-25 18:05 | dbaz | Modules | => Core |
| 2017-08-25 18:05 | dbaz | Triggers an Emergency Pack | => No |
| 2017-08-25 18:05 | dbaz | Issue generated from | 0036708 |
| 2017-08-25 18:05 | dbaz | Relationship added | related to 0036708 |
| 2017-08-25 18:05 | dbaz | Review Assigned To | => caristu |
| 2017-08-25 18:09 | hgbot | Checkin | |
| 2017-08-25 18:09 | hgbot | Note Added: 0098663 | |
| 2017-08-25 18:09 | hgbot | Status | new => resolved |
| 2017-08-25 18:09 | hgbot | Resolution | open => fixed |
| 2017-08-25 18:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c827d58b415539a7e65eb96e26ab781a65cf0294 [^] |
| 2017-08-28 09:55 | alostale | Relationship added | duplicate of 0036014 |
| 2017-08-28 14:45 | alostale | Relationship replaced | related to 0036014 |
| 2017-09-01 08:33 | caristu | Description Updated | View Revisions |
| 2017-09-01 08:36 | caristu | Description Updated | View Revisions |
| 2017-09-01 08:53 | caristu | Note Added: 0098767 | |
| 2017-09-01 08:53 | caristu | Status | resolved => closed |
| 2017-09-01 08:53 | caristu | Fixed in Version | => 3.0PR17Q4 |
| 2017-09-04 16:02 | caristu | Note Added: 0098815 | |
| 2017-09-21 16:49 | hudsonbot | Checkin | |
| 2017-09-21 16:49 | hudsonbot | Note Added: 0099333 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |