Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036724Openbravo ERPA. Platformpublic2017-08-25 18:052017-09-21 16:49
Reporterdbaz 
Assigned Todbaz 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036724: CSSMinimizer does not work well with "quotes" property
DescriptionCSSMinimizer does not work well with "quotes" property

This property accepts several arguments:
https://www.w3schools.com/cssref/pr_gen_quotes.asp [^]

CSSMinimizer has a feature to remove duplicated parameters if exist. This works ok with most of the properties, e.g. "margin", where "100% 100%" or "100% 100% 100% 100%" can be simplified to just "100%", but in the case of "quotes", having only one parameter does not assume that the remaining ones have the same value, so this simplification cannot be performed, and all the parameters should be declared in a explicit way (otherwise, the missing one will adopt the default value).
Steps To ReproduceInclude in any CSS loaded within the application.
quotes: '\0027' '\0027';

With the modules NOT in development, notice that the compressed CSS has only "quotes: '\0027';". (With this simplification the CSS draws " instead of ')
Proposed SolutionAvoid the function "simplifyParameters" of CSSMinimizer be executed if the property is "quotes"
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036708 closed dbaz Openbravo ERP CSSMinimizer does not work well with "transform-origin" property 
related to feature request 0036014 new jorge-garcia Retail Modules Include source maps for our javascript files 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-25 18:05dbazNew Issue
2017-08-25 18:05dbazAssigned To => dbaz
2017-08-25 18:05dbazModules => Core
2017-08-25 18:05dbazTriggers an Emergency Pack => No
2017-08-25 18:05dbazIssue generated from0036708
2017-08-25 18:05dbazRelationship addedrelated to 0036708
2017-08-25 18:05dbazReview Assigned To => caristu
2017-08-25 18:09hgbotCheckin
2017-08-25 18:09hgbotNote Added: 0098663
2017-08-25 18:09hgbotStatusnew => resolved
2017-08-25 18:09hgbotResolutionopen => fixed
2017-08-25 18:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c827d58b415539a7e65eb96e26ab781a65cf0294 [^]
2017-08-28 09:55alostaleRelationship addedduplicate of 0036014
2017-08-28 14:45alostaleRelationship replacedrelated to 0036014
2017-09-01 08:33caristuDescription Updatedbug_revision_view_page.php?rev_id=15781#r15781
2017-09-01 08:36caristuDescription Updatedbug_revision_view_page.php?rev_id=15782#r15782
2017-09-01 08:53caristuNote Added: 0098767
2017-09-01 08:53caristuStatusresolved => closed
2017-09-01 08:53caristuFixed in Version => 3.0PR17Q4
2017-09-04 16:02caristuNote Added: 0098815
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099333

Notes
(0098663)
hgbot   
2017-08-25 18:09   
Repository: erp/devel/pi
Changeset: c827d58b415539a7e65eb96e26ab781a65cf0294
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Aug 25 18:08:28 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c827d58b415539a7e65eb96e26ab781a65cf0294 [^]

Fixed issue 36724: 'quotes' css property now is properly minimized

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java
---
(0098767)
caristu   
2017-09-01 08:53   
Code reviewed + tested OK.
(0098815)
caristu   
2017-09-04 16:02   
Created a pull request[1] in owner's library.

[1] https://github.com/barryvan/CSSMin/pull/22 [^]
(0099333)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test