Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036710 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | minor | always | 2017-08-24 11:13 | 2017-09-21 16:49 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 966241a1d691 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036710: CSSMinimizer does not work well with "background-size" property | |||||||
| Description | CSSMinimizer does not work well with "background-size" property This property can have up two arguments (width and height) https://www.w3schools.com/cssref/css3_pr_background-size.asp [^] The default value is "auto". CSSMinimizer has a feature to remove duplicated parameters if exist. This works ok with most of the properties, e.g. "margin", where "100% 100%" or "100% 100% 100% 100%" can be simplified to just "100%", but in the case of "background-size", having only one parameter does not assume that the other one has the same value, so this simplification cannot be performed, and all the parameters should be declared in a explicit way (otherwise, the missing one will adopt the default 'auto' value). | |||||||
| Steps To Reproduce | Include in any CSS loaded within the application. background-size: 100% 100%; With the modules NOT in development, notice that the compressed CSS has only "background-size: 100%;". (As explained before, this simplification is equivalent to "background-size 100% auto") | |||||||
| Proposed Solution | Avoid the function "simplifyParameters" of CSSMinimizer be executed if the property is "background-size". | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0098628) hgbot (developer) 2017-08-24 11:29 |
Repository: erp/devel/pi Changeset: 966241a1d691d0f5d12aa1ecc6e8dac26552f368 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Thu Aug 24 11:28:37 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/966241a1d691d0f5d12aa1ecc6e8dac26552f368 [^] Fixed issue 36710: 'background-size' css property now is properly minimized --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java --- |
|
(0098630) caristu (developer) 2017-08-24 12:18 edited on: 2017-08-24 12:20 |
Note that this issue is already solved[1] in the latest version of the CSSMin library. The fix is exactly the same as the proposed solution. [1] https://github.com/barryvan/CSSMin/commit/24d4ed987a1b52e46e544369038346b084fad595 [^] |
|
(0098631) caristu (developer) 2017-08-24 12:34 edited on: 2017-08-24 12:34 |
Code reviewed + tested OK. |
|
(0099323) hudsonbot (developer) 2017-09-21 16:49 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-08-24 11:13 | dbaz | New Issue | |
| 2017-08-24 11:13 | dbaz | Assigned To | => caristu |
| 2017-08-24 11:13 | dbaz | Modules | => Core |
| 2017-08-24 11:13 | dbaz | Triggers an Emergency Pack | => No |
| 2017-08-24 11:13 | dbaz | Issue generated from | 0036708 |
| 2017-08-24 11:27 | dbaz | Assigned To | caristu => dbaz |
| 2017-08-24 11:27 | dbaz | Review Assigned To | => caristu |
| 2017-08-24 11:27 | dbaz | Relationship added | related to 0036708 |
| 2017-08-24 11:29 | hgbot | Checkin | |
| 2017-08-24 11:29 | hgbot | Note Added: 0098628 | |
| 2017-08-24 11:29 | hgbot | Status | new => resolved |
| 2017-08-24 11:29 | hgbot | Resolution | open => fixed |
| 2017-08-24 11:29 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/966241a1d691d0f5d12aa1ecc6e8dac26552f368 [^] |
| 2017-08-24 12:03 | caristu | Steps to Reproduce Updated | View Revisions |
| 2017-08-24 12:18 | caristu | Note Added: 0098630 | |
| 2017-08-24 12:20 | caristu | Note Edited: 0098630 | View Revisions |
| 2017-08-24 12:32 | caristu | Proposed Solution updated | |
| 2017-08-24 12:34 | caristu | Note Added: 0098631 | |
| 2017-08-24 12:34 | caristu | Status | resolved => closed |
| 2017-08-24 12:34 | caristu | Fixed in Version | => 3.0PR17Q4 |
| 2017-08-24 12:34 | caristu | Note Edited: 0098631 | View Revisions |
| 2017-08-24 12:35 | caristu | Proposed Solution updated | |
| 2017-08-28 09:56 | alostale | Relationship added | related to 0036014 |
| 2017-09-21 16:49 | hudsonbot | Checkin | |
| 2017-09-21 16:49 | hudsonbot | Note Added: 0099323 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |