Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036710Openbravo ERP00. Application dictionarypublic2017-08-24 11:132017-09-21 16:49
Reporterdbaz 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036710: CSSMinimizer does not work well with "background-size" property
DescriptionCSSMinimizer does not work well with "background-size" property

This property can have up two arguments (width and height)
https://www.w3schools.com/cssref/css3_pr_background-size.asp [^]

The default value is "auto". CSSMinimizer has a feature to remove duplicated parameters if exist. This works ok with most of the properties, e.g. "margin", where "100% 100%" or "100% 100% 100% 100%" can be simplified to just "100%", but in the case of "background-size", having only one parameter does not assume that the other one has the same value, so this simplification cannot be performed, and all the parameters should be declared in a explicit way (otherwise, the missing one will adopt the default 'auto' value).
Steps To ReproduceInclude in any CSS loaded within the application.
background-size: 100% 100%;

With the modules NOT in development, notice that the compressed CSS has only "background-size: 100%;". (As explained before, this simplification is equivalent to "background-size 100% auto")
Proposed SolutionAvoid the function "simplifyParameters" of CSSMinimizer be executed if the property is "background-size".
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0036014 new jorge-garcia Retail Modules Include source maps for our javascript files 
related to defect 0036708 closed dbaz Openbravo ERP CSSMinimizer does not work well with "transform-origin" property 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-08-24 11:13dbazNew Issue
2017-08-24 11:13dbazAssigned To => caristu
2017-08-24 11:13dbazOBNetwork customer => No
2017-08-24 11:13dbazModules => Core
2017-08-24 11:13dbazTriggers an Emergency Pack => No
2017-08-24 11:13dbazIssue generated from0036708
2017-08-24 11:27dbazAssigned Tocaristu => dbaz
2017-08-24 11:27dbazReview Assigned To => caristu
2017-08-24 11:27dbazRelationship addedrelated to 0036708
2017-08-24 11:29hgbotCheckin
2017-08-24 11:29hgbotNote Added: 0098628
2017-08-24 11:29hgbotStatusnew => resolved
2017-08-24 11:29hgbotResolutionopen => fixed
2017-08-24 11:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/966241a1d691d0f5d12aa1ecc6e8dac26552f368 [^]
2017-08-24 12:03caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15695#r15695
2017-08-24 12:18caristuNote Added: 0098630
2017-08-24 12:20caristuNote Edited: 0098630bug_revision_view_page.php?bugnote_id=0098630#r15697
2017-08-24 12:32caristuProposed Solution updated
2017-08-24 12:34caristuNote Added: 0098631
2017-08-24 12:34caristuStatusresolved => closed
2017-08-24 12:34caristuFixed in Version => 3.0PR17Q4
2017-08-24 12:34caristuNote Edited: 0098631bug_revision_view_page.php?bugnote_id=0098631#r15702
2017-08-24 12:35caristuProposed Solution updated
2017-08-28 09:56alostaleRelationship addedrelated to 0036014
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099323

Notes
(0098628)
hgbot   
2017-08-24 11:29   
Repository: erp/devel/pi
Changeset: 966241a1d691d0f5d12aa1ecc6e8dac26552f368
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Aug 24 11:28:37 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/966241a1d691d0f5d12aa1ecc6e8dac26552f368 [^]

Fixed issue 36710: 'background-size' css property now is properly minimized

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/CSSMinimizer.java
---
(0098630)
caristu   
2017-08-24 12:18   
(edited on: 2017-08-24 12:20)
Note that this issue is already solved[1] in the latest version of the CSSMin library. The fix is exactly the same as the proposed solution.

[1] https://github.com/barryvan/CSSMin/commit/24d4ed987a1b52e46e544369038346b084fad595 [^]
(0098631)
caristu   
2017-08-24 12:34   
Code reviewed + tested OK.
(0099323)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test