0036452: 2 warnings found in pl code by plpgsql_check

Description

The new plpgsql_check code checking tool for pl-functions and triggers found 2 issues in retail modules which should get fixed.

The first one is just small code cleanup
The 2nd looks like probably real functional bug (type mismatch)

The warnings can be seen in mod-retail job in the new plpgsql_check.log file:
Example:
https://docs.google.com/document/d/18s-UNnWztDHyVFhmx0R2UbhaWpCwK_3CLE2D2GYWdoI/edit#heading=h.abwdfvwl3a29 [^]

Concretely:
a.) unused variable in obfmtc_get_product_taxcategory function
b.) type mismatch in obloy_integration_mod_trg trigger

Steps To Reproduce

run plpgsql_check tool locally or check output of mod-retail job in new artifact
plpgsql_check.log

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0036441

closed

shuehner

Modules

Modularity (needs module in development) check for cube dimensions is not working correctly

Notes
(0097994) shuehner (administrator) 2017-07-10 18:06	The 2nd type-mismatch is probably nearly same as the related issue. in this case coalesce(name,0) is wrong as name is varchar should be '.' instead of 0

(0098821) hgbot (developer) 2017-09-04 21:27	Repository: erp/pmods/org.openbravo.retail.loyalty Changeset: 1bd839e10d137e681b8478478d14c81ddf5ae023 Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Mon Sep 04 14:20:01 2017 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/1bd839e10d137e681b8478478d14c81ddf5ae023 [^] Fixed issue 36452: 2 warnings found in pl code by plpgsql_check - Type mismatch fixed, '.' instead of 0. --- M src-db/database/model/triggers/OBLOY_INTEGRATION_MOD_TRG.xml ---

Issue History
Date Modified	Username	Field	Change
2017-07-10 18:05	shuehner	New Issue
2017-07-10 18:05	shuehner	Assigned To	=> Retail
2017-07-10 18:05	shuehner	Triggers an Emergency Pack	=> No
2017-07-10 18:06	shuehner	Relationship added	related to 0036441
2017-07-10 18:06	shuehner	Note Added: 0097994
2017-09-04 16:51	rqueralta	Assigned To	Retail => rqueralta
2017-09-04 16:51	rqueralta	Status	new => scheduled
2017-09-04 21:27	hgbot	Checkin
2017-09-04 21:27	hgbot	Note Added: 0098821
2017-09-04 21:27	hgbot	Status	scheduled => resolved
2017-09-04 21:27	hgbot	Resolution	open => fixed
2017-09-04 21:27	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/1bd839e10d137e681b8478478d14c81ddf5ae023 [^]
2017-09-15 14:21	marvintm	Review Assigned To	=> marvintm
2017-09-15 14:21	marvintm	Status	resolved => closed
2017-09-15 14:21	marvintm	Fixed in Version	=> RR17Q4