Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036452Retail ModulesWeb POSpublic2017-07-10 18:052017-09-15 14:21
Reportershuehner 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036452: 2 warnings found in pl code by plpgsql_check
DescriptionThe new plpgsql_check code checking tool for pl-functions and triggers found 2 issues in retail modules which should get fixed.

The first one is just small code cleanup
The 2nd looks like probably real functional bug (type mismatch)

The warnings can be seen in mod-retail job in the new plpgsql_check.log file:
Example:
https://docs.google.com/document/d/18s-UNnWztDHyVFhmx0R2UbhaWpCwK_3CLE2D2GYWdoI/edit#heading=h.abwdfvwl3a29 [^]

Concretely:
a.) unused variable in obfmtc_get_product_taxcategory function
b.) type mismatch in obloy_integration_mod_trg trigger
Steps To Reproducerun plpgsql_check tool locally or check output of mod-retail job in new artifact
plpgsql_check.log
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036441 closed shuehner Modules Modularity (needs module in development) check for cube dimensions is not working correctly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-10 18:05shuehnerNew Issue
2017-07-10 18:05shuehnerAssigned To => Retail
2017-07-10 18:05shuehnerTriggers an Emergency Pack => No
2017-07-10 18:06shuehnerRelationship addedrelated to 0036441
2017-07-10 18:06shuehnerNote Added: 0097994
2017-09-04 16:51rqueraltaAssigned ToRetail => rqueralta
2017-09-04 16:51rqueraltaStatusnew => scheduled
2017-09-04 21:27hgbotCheckin
2017-09-04 21:27hgbotNote Added: 0098821
2017-09-04 21:27hgbotStatusscheduled => resolved
2017-09-04 21:27hgbotResolutionopen => fixed
2017-09-04 21:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/1bd839e10d137e681b8478478d14c81ddf5ae023 [^]
2017-09-15 14:21marvintmReview Assigned To => marvintm
2017-09-15 14:21marvintmStatusresolved => closed
2017-09-15 14:21marvintmFixed in Version => RR17Q4

Notes
(0097994)
shuehner   
2017-07-10 18:06   
The 2nd type-mismatch is probably nearly same as the related issue.
in this case coalesce(name,0) is wrong as name is varchar should be '.' instead of 0
(0098821)
hgbot   
2017-09-04 21:27   
Repository: erp/pmods/org.openbravo.retail.loyalty
Changeset: 1bd839e10d137e681b8478478d14c81ddf5ae023
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Sep 04 14:20:01 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/1bd839e10d137e681b8478478d14c81ddf5ae023 [^]

Fixed issue 36452: 2 warnings found in pl code by plpgsql_check

- Type mismatch fixed, '.' instead of 0.

---
M src-db/database/model/triggers/OBLOY_INTEGRATION_MOD_TRG.xml
---