Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036270 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 03. Procurement management | major | always | 2017-06-19 09:15 | 2017-10-31 12:47 | |||
| Reporter | dmiguelez | View Status | public | |||||
| Assigned To | alekosmp86 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 3753ecf11172 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | dmiguelez | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036270: Wrong string comparison in Requisition To Order | |||||||
| Description | Wrong string comparison in Requisition To Order. lines[i].secuomname.equals("**") can result in a n.p.e if lines[i].secuomname is null. It is better to use StringUtils in this case | |||||||
| Steps To Reproduce | In Requistion To Order java class, change search for secuomname.equals. This cases must be changed to StringUtils.equals | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0097504) hgbot (developer) 2017-06-20 11:13 |
Repository: erp/devel/pi Changeset: 3753ecf11172dfcdc133f4abd20803416d118d91 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Wed Jun 14 15:20:16 2017 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/3753ecf11172dfcdc133f4abd20803416d118d91 [^] Fixes issue 36270: When generating a PO from Requisition To Order window for a product with AUM. Strings comparison are made with StringUtils.equals(<string1>, <string2>) instead of <string>.equals(<string>), due to the null check in the parameters. --- M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java --- |
|
(0097505) hgbot (developer) 2017-06-20 11:13 |
Repository: erp/devel/pi Changeset: 1060aa4441df612fffe664f78d83c668d800e7b1 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Mon Jun 19 09:44:01 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1060aa4441df612fffe664f78d83c668d800e7b1 [^] Related to Issue 36270. Fixes all places in which the StringUtils comparison should be used instead of variable.equals("string") --- M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java --- |
|
(0097506) dmiguelez (viewer) 2017-06-20 11:18 |
Code Review + Testing Ok |
|
(0097511) hgbot (developer) 2017-06-20 13:36 |
Repository: erp/devel/pi Changeset: 2ffddb16d7358be7dae0168ed94a630312e67930 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue Jun 20 13:35:04 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2ffddb16d7358be7dae0168ed94a630312e67930 [^] Related to Issue 36270. Fixes all places in which the StringUtils comparison should be used instead of variable.equals("string") --- M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java --- |
|
(0097521) hudsonbot (viewer) 2017-06-20 16:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8518c867b17c [^] Maturity status: Test |
|
(0097522) hudsonbot (viewer) 2017-06-20 16:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8518c867b17c [^] Maturity status: Test |
|
(0097567) hudsonbot (viewer) 2017-06-21 23:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5e0471c14ef8 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-06-19 09:15 | dmiguelez | New Issue | |
| 2017-06-19 09:15 | dmiguelez | Assigned To | => Triage Finance |
| 2017-06-19 09:15 | dmiguelez | OBNetwork customer | => No |
| 2017-06-19 09:15 | dmiguelez | Modules | => Core |
| 2017-06-19 09:15 | dmiguelez | Triggers an Emergency Pack | => No |
| 2017-06-19 09:15 | dmiguelez | Assigned To | Triage Finance => dmiguelez |
| 2017-06-19 09:15 | dmiguelez | Status | new => scheduled |
| 2017-06-20 11:13 | hgbot | Checkin | |
| 2017-06-20 11:13 | hgbot | Note Added: 0097504 | |
| 2017-06-20 11:13 | hgbot | Status | scheduled => resolved |
| 2017-06-20 11:13 | hgbot | Resolution | open => fixed |
| 2017-06-20 11:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3753ecf11172dfcdc133f4abd20803416d118d91 [^] |
| 2017-06-20 11:13 | hgbot | Checkin | |
| 2017-06-20 11:13 | hgbot | Note Added: 0097505 | |
| 2017-06-20 11:18 | dmiguelez | Review Assigned To | => dmiguelez |
| 2017-06-20 11:18 | dmiguelez | Note Added: 0097506 | |
| 2017-06-20 11:18 | dmiguelez | Status | resolved => closed |
| 2017-06-20 11:19 | aferraz | Assigned To | dmiguelez => alekosmp86 |
| 2017-06-20 11:19 | aferraz | Fixed in Version | => 3.0PR17Q3 |
| 2017-06-20 13:36 | hgbot | Checkin | |
| 2017-06-20 13:36 | hgbot | Note Added: 0097511 | |
| 2017-06-20 16:31 | hudsonbot | Checkin | |
| 2017-06-20 16:31 | hudsonbot | Note Added: 0097521 | |
| 2017-06-20 16:31 | hudsonbot | Checkin | |
| 2017-06-20 16:31 | hudsonbot | Note Added: 0097522 | |
| 2017-06-21 23:43 | hudsonbot | Checkin | |
| 2017-06-21 23:43 | hudsonbot | Note Added: 0097567 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |