Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036270Openbravo ERP03. Procurement managementpublic2017-06-19 09:152017-10-31 12:47
Reporterdmiguelez 
Assigned Toalekosmp86 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036270: Wrong string comparison in Requisition To Order
DescriptionWrong string comparison in Requisition To Order.

lines[i].secuomname.equals("**") can result in a n.p.e if lines[i].secuomname is null. It is better to use StringUtils in this case
Steps To ReproduceIn Requistion To Order java class, change search for secuomname.equals.

This cases must be changed to StringUtils.equals
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 09:15dmiguelezNew Issue
2017-06-19 09:15dmiguelezAssigned To => Triage Finance
2017-06-19 09:15dmiguelezModules => Core
2017-06-19 09:15dmiguelezTriggers an Emergency Pack => No
2017-06-19 09:15dmiguelezAssigned ToTriage Finance => dmiguelez
2017-06-19 09:15dmiguelezStatusnew => scheduled
2017-06-20 11:13hgbotCheckin
2017-06-20 11:13hgbotNote Added: 0097504
2017-06-20 11:13hgbotStatusscheduled => resolved
2017-06-20 11:13hgbotResolutionopen => fixed
2017-06-20 11:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3753ecf11172dfcdc133f4abd20803416d118d91 [^]
2017-06-20 11:13hgbotCheckin
2017-06-20 11:13hgbotNote Added: 0097505
2017-06-20 11:18dmiguelezReview Assigned To => dmiguelez
2017-06-20 11:18dmiguelezNote Added: 0097506
2017-06-20 11:18dmiguelezStatusresolved => closed
2017-06-20 11:19aferrazAssigned Todmiguelez => alekosmp86
2017-06-20 11:19aferrazFixed in Version => 3.0PR17Q3
2017-06-20 13:36hgbotCheckin
2017-06-20 13:36hgbotNote Added: 0097511
2017-06-20 16:31hudsonbotCheckin
2017-06-20 16:31hudsonbotNote Added: 0097521
2017-06-20 16:31hudsonbotCheckin
2017-06-20 16:31hudsonbotNote Added: 0097522
2017-06-21 23:43hudsonbotCheckin
2017-06-21 23:43hudsonbotNote Added: 0097567

Notes
(0097504)
hgbot   
2017-06-20 11:13   
Repository: erp/devel/pi
Changeset: 3753ecf11172dfcdc133f4abd20803416d118d91
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jun 14 15:20:16 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/3753ecf11172dfcdc133f4abd20803416d118d91 [^]

Fixes issue 36270: When generating a PO from Requisition To Order window for a product
with AUM.

Strings comparison are made with StringUtils.equals(<string1>, <string2>) instead
of <string>.equals(<string>), due to the null check in the parameters.

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
---
(0097505)
hgbot   
2017-06-20 11:13   
Repository: erp/devel/pi
Changeset: 1060aa4441df612fffe664f78d83c668d800e7b1
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 19 09:44:01 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1060aa4441df612fffe664f78d83c668d800e7b1 [^]

Related to Issue 36270. Fixes all places in which the StringUtils comparison
should be used instead of variable.equals("string")

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
---
(0097506)
dmiguelez   
2017-06-20 11:18   
Code Review + Testing Ok
(0097511)
hgbot   
2017-06-20 13:36   
Repository: erp/devel/pi
Changeset: 2ffddb16d7358be7dae0168ed94a630312e67930
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 20 13:35:04 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2ffddb16d7358be7dae0168ed94a630312e67930 [^]

Related to Issue 36270. Fixes all places in which the StringUtils comparison
should be used instead of variable.equals("string")

---
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
---
(0097521)
hudsonbot   
2017-06-20 16:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8518c867b17c [^]
Maturity status: Test
(0097522)
hudsonbot   
2017-06-20 16:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8518c867b17c [^]
Maturity status: Test
(0097567)
hudsonbot   
2017-06-21 23:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5e0471c14ef8 [^]
Maturity status: Test