Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036173
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Payment Aging Balance Reportmajoralways2017-06-02 15:432017-06-07 11:02
Reportermarkmm82View Statuspublic 
Assigned Tomarkmm82 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona5cf7215652f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Regression introduced in release
Summary

0036173: Performance problems in Aging reports returning "multiple" instead of "scrollable" queries.

DescriptionAging reports have changed the queries returning "multiple" instead of "scrollable" data, this way it is losing all the advantage that give us the scrollables reducing memory usage, and thus avoid performance issues.

Is needed to use "scrollable" queries instead of "multiple".
Steps To ReproduceCheck src/org/openbravo/agingbalance/ad_reports/AgingDao_data.xsql methods are using return as "multiple" instead of "scrollable"
Proposed SolutionChange the xsql file methods to use "scrollable" instead of "multiple".
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0035531 closedmarkmm82 Modules The browswer get stucked when printing the receivable aging schedule report showing details and having a lot of invoices pending 
related to defect 0035764 closedmarkmm82 Openbravo ERP The browswer get stucked when printing the receivable aging schedule report showing details and having a lot of invoices pending 

-  Notes
(0097152)
markmm82 (developer)
2017-06-05 22:01

 Test Plan 1:
In a 17Q1 instance install the Payment Aging Balance Report module.
As System Admin
  - Go to Preference window
    Edit "ReportsLimit" preference and set "Value"=1

As F&B International Group Admin

  - Go to Receivables Aging Schedule report window
    Set F&B España, S.A org and "From Date"=04-04-2016 and click in HTML Format buttom
    Check that a warning message is shown in both windows: showing selected filters and results:
"The filtering criteria you have specified for this report return a number of rows that exceeds the maximum allowed. The limit of rows to display in a report is 2. Please, use more selective filtering criteria and execute the report again."

Repeat the same steps but checking "Show details" option and notice the message is shown too.

Test Plan 2:
In a 17Q1 instance install the Payment Aging Balance Report module.
As System Admin
  - Go to Preference window
    Edit "ReportsLimit" preference and set "Value"=1

As F&B International Group Admin

  - Go to Payables Aging Schedule report window
    Set F&B España, S.A org and "From Date"=04-04-2016 and click in HTML Format buttom
    Check that a warning message is shown in both windows: showing selected filters and results:
"The filtering criteria you have specified for this report return a number of rows that exceeds the maximum allowed. The limit of rows to display in a report is 2. Please, use more selective filtering criteria and execute the report again."

Repeat the same steps but checking "Show details" option and notice the message is shown too.
(0097187)
hgbot (developer)
2017-06-07 11:00

 Repository: erp/mods/org.openbravo.agingbalance
Changeset: a5cf7215652fe9e595d3332743b34bd476a3e8d1
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jun 05 15:57:00 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/a5cf7215652fe9e595d3332743b34bd476a3e8d1 [^]

Fixes issue 36173: Performance problem in Aging Balance Reports module

Aging Balance Reports module has changed the queries returning "multiple" instead of
"scrollable" data, this way it is losing all the advantage that give us the scrollables
mainly reducing memory usage, and thus avoid performance issues.

Changed the xsql file methods to use "scrollable" instead of "multiple" as return
type.

---
M src/org/openbravo/agingbalance/ad_reports/AgingDao.java
M src/org/openbravo/agingbalance/ad_reports/AgingDao_data.xsql
---
(0097188)
hgbot (developer)
2017-06-07 11:00

 Repository: erp/mods/org.openbravo.agingbalance
Changeset: 3de97920a0e47b0cc5f304f8313fa170a083b0c7
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 07 10:43:19 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/3de97920a0e47b0cc5f304f8313fa170a083b0c7 [^]

Related to issue 36173: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0097189)
aferraz (manager)
2017-06-07 11:02

 Code review + Testing OK

- Issue History
Date Modified Username Field Change
2017-06-02 15:43 markmm82 New Issue
2017-06-02 15:43 markmm82 Assigned To => markmm82
2017-06-05 09:53 aferraz Relationship added related to 0035764
2017-06-05 09:53 aferraz Relationship added caused by 0035531
2017-06-05 22:01 markmm82 Status new => scheduled
2017-06-05 22:01 markmm82 Note Added: 0097152
2017-06-07 11:00 hgbot Checkin
2017-06-07 11:00 hgbot Note Added: 0097187
2017-06-07 11:00 hgbot Status scheduled => resolved
2017-06-07 11:00 hgbot Resolution open => fixed
2017-06-07 11:00 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/a5cf7215652fe9e595d3332743b34bd476a3e8d1 [^]
2017-06-07 11:00 hgbot Checkin
2017-06-07 11:00 hgbot Note Added: 0097188
2017-06-07 11:02 aferraz Review Assigned To => aferraz
2017-06-07 11:02 aferraz Note Added: 0097189
2017-06-07 11:02 aferraz Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker