Openbravo Issue Tracking System - Modules
View Issue Details
0036173ModulesPayment Aging Balance Reportpublic2017-06-02 15:432017-06-07 11:02
markmm82 
markmm82 
normalmajoralways
closedfixed 
5
 
 
aferraz
0036173: Performance problems in Aging reports returning "multiple" instead of "scrollable" queries.
Aging reports have changed the queries returning "multiple" instead of "scrollable" data, this way it is losing all the advantage that give us the scrollables reducing memory usage, and thus avoid performance issues.

Is needed to use "scrollable" queries instead of "multiple".
Check src/org/openbravo/agingbalance/ad_reports/AgingDao_data.xsql methods are using return as "multiple" instead of "scrollable"
Change the xsql file methods to use "scrollable" instead of "multiple".
No tags attached.
caused by defect 0035531 closed markmm82 Modules The browswer get stucked when printing the receivable aging schedule report showing details and having a lot of invoices pending 
related to defect 0035764 closed markmm82 Openbravo ERP The browswer get stucked when printing the receivable aging schedule report showing details and having a lot of invoices pending 
Issue History
2017-06-02 15:43markmm82New Issue
2017-06-02 15:43markmm82Assigned To => markmm82
2017-06-05 09:53aferrazRelationship addedrelated to 0035764
2017-06-05 09:53aferrazRelationship addedcaused by 0035531
2017-06-05 22:01markmm82Statusnew => scheduled
2017-06-05 22:01markmm82Note Added: 0097152
2017-06-07 11:00hgbotCheckin
2017-06-07 11:00hgbotNote Added: 0097187
2017-06-07 11:00hgbotStatusscheduled => resolved
2017-06-07 11:00hgbotResolutionopen => fixed
2017-06-07 11:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/a5cf7215652fe9e595d3332743b34bd476a3e8d1 [^]
2017-06-07 11:00hgbotCheckin
2017-06-07 11:00hgbotNote Added: 0097188
2017-06-07 11:02aferrazReview Assigned To => aferraz
2017-06-07 11:02aferrazNote Added: 0097189
2017-06-07 11:02aferrazStatusresolved => closed

Notes
(0097152)
markmm82   
2017-06-05 22:01   
Test Plan 1:
In a 17Q1 instance install the Payment Aging Balance Report module.
As System Admin
  - Go to Preference window
    Edit "ReportsLimit" preference and set "Value"=1

As F&B International Group Admin

  - Go to Receivables Aging Schedule report window
    Set F&B España, S.A org and "From Date"=04-04-2016 and click in HTML Format buttom
    Check that a warning message is shown in both windows: showing selected filters and results:
"The filtering criteria you have specified for this report return a number of rows that exceeds the maximum allowed. The limit of rows to display in a report is 2. Please, use more selective filtering criteria and execute the report again."

Repeat the same steps but checking "Show details" option and notice the message is shown too.

Test Plan 2:
In a 17Q1 instance install the Payment Aging Balance Report module.
As System Admin
  - Go to Preference window
    Edit "ReportsLimit" preference and set "Value"=1

As F&B International Group Admin

  - Go to Payables Aging Schedule report window
    Set F&B España, S.A org and "From Date"=04-04-2016 and click in HTML Format buttom
    Check that a warning message is shown in both windows: showing selected filters and results:
"The filtering criteria you have specified for this report return a number of rows that exceeds the maximum allowed. The limit of rows to display in a report is 2. Please, use more selective filtering criteria and execute the report again."

Repeat the same steps but checking "Show details" option and notice the message is shown too.
(0097187)
hgbot   
2017-06-07 11:00   
Repository: erp/mods/org.openbravo.agingbalance
Changeset: a5cf7215652fe9e595d3332743b34bd476a3e8d1
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jun 05 15:57:00 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/a5cf7215652fe9e595d3332743b34bd476a3e8d1 [^]

Fixes issue 36173: Performance problem in Aging Balance Reports module

Aging Balance Reports module has changed the queries returning "multiple" instead of
"scrollable" data, this way it is losing all the advantage that give us the scrollables
mainly reducing memory usage, and thus avoid performance issues.

Changed the xsql file methods to use "scrollable" instead of "multiple" as return
type.

---
M src/org/openbravo/agingbalance/ad_reports/AgingDao.java
M src/org/openbravo/agingbalance/ad_reports/AgingDao_data.xsql
---
(0097188)
hgbot   
2017-06-07 11:00   
Repository: erp/mods/org.openbravo.agingbalance
Changeset: 3de97920a0e47b0cc5f304f8313fa170a083b0c7
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 07 10:43:19 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/3de97920a0e47b0cc5f304f8313fa170a083b0c7 [^]

Related to issue 36173: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0097189)
aferraz   
2017-06-07 11:02   
Code review + Testing OK