Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035979
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2017-05-11 19:152017-05-29 17:43
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision14a400b89ef1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2017-04-08
Regression introduced in releasepi
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^]
Triggers an Emergency PackNo
Summary

0035979: The size of the company image in the navigation bar is not updated properly

DescriptionThe size of the company image in the navigation bar is not updated properly when switching between different clients, this is because since[1] its value is cached as part of the static resources

[1] 35852: Add a mechanism to cache the static resources
Steps To Reproduce1) Log-in as F&B International Group
2) Notice that the company image is displayed properly
3) Switch to System Administrator Role -> the company image overlaps the OB3 logo (see attached)
Proposed SolutionCalculate the dynamic values with the SessionDynamic request instead of calculating them with the Application component
TagsNo tags attached.
Attached Filespng file icon wrongImage.png [^] (7,167 bytes) 2017-05-11 19:15

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0035852 closedcaristu Add a mechanism to cache the static resources 

-  Notes
(0096577)
hgbot (developer)
2017-05-15 08:35

 Repository: erp/devel/api-checks
Changeset: de8379bb0033cb2fcb6550dc0d639cbef77eecec
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 15 08:34:27 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/de8379bb0033cb2fcb6550dc0d639cbef77eecec [^]

related to issue 35979: methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096578)
hgbot (developer)
2017-05-15 08:35

 Repository: erp/devel/pi
Changeset: 14a400b89ef1980f3f6ea37496837b36cbabfcfe
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 15 08:33:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14a400b89ef1980f3f6ea37496837b36cbabfcfe [^]

fixes issue 35979: The size of the company image is not updated properly

After the changes introduced on issue 0035852, the values generated by the application component are cached together with the rest of the javascript static code. Some of those values (like the company image) can be differente depending on the session context, therefore they can not be cached. For this reason now they are calculated with the SessionDynamic request.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationDynamicComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-dynamic-js.ftl
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0096584)
hgbot (developer)
2017-05-15 10:39

 Repository: retail/api-checks-retail
Changeset: 7cf04d27cf95da1363efe97146d0cb38b802497a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 15 10:39:09 2017 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/7cf04d27cf95da1363efe97146d0cb38b802497a [^]

Related to issue 35979. methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096594)
alostale (manager)
2017-05-15 13:24

 reviewed + tested
(0096839)
hgbot (developer)
2017-05-29 09:17

 Repository: retail/api-checks-retail
Changeset: 1bd133f6b3487cfeb2be6aa5567c5c64c680d814
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 29 09:17:17 2017 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/1bd133f6b3487cfeb2be6aa5567c5c64c680d814 [^]

Fixed issue 35972. Approved API change. Related to issue 35979. methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096966)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-05-11 19:15 caristu New Issue
2017-05-11 19:15 caristu Assigned To => caristu
2017-05-11 19:15 caristu Modules => Core
2017-05-11 19:15 caristu Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^]
2017-05-11 19:15 caristu Triggers an Emergency Pack => No
2017-05-11 19:15 caristu Regression level => Pre packaging ( pi )
2017-05-11 19:15 caristu Regression date => 2017-04-08
2017-05-11 19:15 caristu Regression introduced in release => pi
2017-05-11 19:15 caristu File Added: wrongImage.png
2017-05-11 19:16 caristu Relationship added caused by 0035852
2017-05-11 19:18 caristu Status new => scheduled
2017-05-15 08:35 hgbot Checkin
2017-05-15 08:35 hgbot Note Added: 0096577
2017-05-15 08:35 hgbot Checkin
2017-05-15 08:35 hgbot Note Added: 0096578
2017-05-15 08:35 hgbot Status scheduled => resolved
2017-05-15 08:35 hgbot Resolution open => fixed
2017-05-15 08:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/14a400b89ef1980f3f6ea37496837b36cbabfcfe [^]
2017-05-15 08:38 caristu Review Assigned To => alostale
2017-05-15 10:39 hgbot Checkin
2017-05-15 10:39 hgbot Note Added: 0096584
2017-05-15 13:24 alostale Note Added: 0096594
2017-05-15 13:24 alostale Status resolved => closed
2017-05-15 13:24 alostale Fixed in Version => 3.0PR17Q3
2017-05-29 09:17 hgbot Checkin
2017-05-29 09:17 hgbot Note Added: 0096839
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096966

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker