Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035979Openbravo ERPA. Platformpublic2017-05-11 19:152017-05-29 17:43
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2017-04-08
Regression introduced in releasepi
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^]
Triggers an Emergency PackNo
Summary0035979: The size of the company image in the navigation bar is not updated properly
DescriptionThe size of the company image in the navigation bar is not updated properly when switching between different clients, this is because since[1] its value is cached as part of the static resources

[1] 35852: Add a mechanism to cache the static resources
Steps To Reproduce1) Log-in as F&B International Group
2) Notice that the company image is displayed properly
3) Switch to System Administrator Role -> the company image overlaps the OB3 logo (see attached)
Proposed SolutionCalculate the dynamic values with the SessionDynamic request instead of calculating them with the Application component
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0035852 closed caristu Add a mechanism to cache the static resources 
Attached Filespng wrongImage.png (7,167) 2017-05-11 19:15
https://issues.openbravo.com/file_download.php?file_id=10749&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-05-11 19:15caristuNew Issue
2017-05-11 19:15caristuAssigned To => caristu
2017-05-11 19:15caristuModules => Core
2017-05-11 19:15caristuRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^]
2017-05-11 19:15caristuTriggers an Emergency Pack => No
2017-05-11 19:15caristuRegression level => Pre packaging ( pi )
2017-05-11 19:15caristuRegression date => 2017-04-08
2017-05-11 19:15caristuRegression introduced in release => pi
2017-05-11 19:15caristuFile Added: wrongImage.png
2017-05-11 19:16caristuRelationship addedcaused by 0035852
2017-05-11 19:18caristuStatusnew => scheduled
2017-05-15 08:35hgbotCheckin
2017-05-15 08:35hgbotNote Added: 0096577
2017-05-15 08:35hgbotCheckin
2017-05-15 08:35hgbotNote Added: 0096578
2017-05-15 08:35hgbotStatusscheduled => resolved
2017-05-15 08:35hgbotResolutionopen => fixed
2017-05-15 08:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/14a400b89ef1980f3f6ea37496837b36cbabfcfe [^]
2017-05-15 08:38caristuReview Assigned To => alostale
2017-05-15 10:39hgbotCheckin
2017-05-15 10:39hgbotNote Added: 0096584
2017-05-15 13:24alostaleNote Added: 0096594
2017-05-15 13:24alostaleStatusresolved => closed
2017-05-15 13:24alostaleFixed in Version => 3.0PR17Q3
2017-05-29 09:17hgbotCheckin
2017-05-29 09:17hgbotNote Added: 0096839
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096966

Notes
(0096577)
hgbot   
2017-05-15 08:35   
Repository: erp/devel/api-checks
Changeset: de8379bb0033cb2fcb6550dc0d639cbef77eecec
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 15 08:34:27 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/de8379bb0033cb2fcb6550dc0d639cbef77eecec [^]

related to issue 35979: methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096578)
hgbot   
2017-05-15 08:35   
Repository: erp/devel/pi
Changeset: 14a400b89ef1980f3f6ea37496837b36cbabfcfe
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 15 08:33:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14a400b89ef1980f3f6ea37496837b36cbabfcfe [^]

fixes issue 35979: The size of the company image is not updated properly

After the changes introduced on issue 0035852, the values generated by the application component are cached together with the rest of the javascript static code. Some of those values (like the company image) can be differente depending on the session context, therefore they can not be cached. For this reason now they are calculated with the SessionDynamic request.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationDynamicComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-dynamic-js.ftl
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0096584)
hgbot   
2017-05-15 10:39   
Repository: retail/api-checks-retail
Changeset: 7cf04d27cf95da1363efe97146d0cb38b802497a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 15 10:39:09 2017 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/7cf04d27cf95da1363efe97146d0cb38b802497a [^]

Related to issue 35979. methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096594)
alostale   
2017-05-15 13:24   
reviewed + tested
(0096839)
hgbot   
2017-05-29 09:17   
Repository: retail/api-checks-retail
Changeset: 1bd133f6b3487cfeb2be6aa5567c5c64c680d814
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 29 09:17:17 2017 +0200
URL: http://code.openbravo.com/retail/api-checks-retail/rev/1bd133f6b3487cfeb2be6aa5567c5c64c680d814 [^]

Fixed issue 35972. Approved API change. Related to issue 35979. methods removed in ApplicationComponent

---
M java/reference/java.japi.gz
---
(0096966)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test