Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035966
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. PlatformminorN/A2017-05-10 10:122017-05-29 17:43
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision2406203ff921
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2017-04-06
Regression introduced in releasepi
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
Triggers an Emergency PackNo
Summary

0035966: Custom skins for the login page are not working

DescriptionAfter the changes introduced on issue 0035386 the login page skin can not be customized properly.
Steps To Reproduce1) Install the module Skin:Blue
2) Log-in as System Admin and in the [Session Preferences] window, choose the "Blue" skin
3) Log-out. Notice that the styles of the log-in page are missing (see attached image).
Proposed SolutionThe problem is caused because the Login page now uses a new css file (loginStyles.css) which is not present in the expected location that contains the skin resources.
TagsNo tags attached.
Attached Filespng file icon loginWrong.png [^] (14,226 bytes) 2017-05-10 10:13

- Relationships Relation Graph ] Dependency Graph ]
caused by feature request 0035386 closedcaristu Login page needs some clean up 

-  Notes
(0096517)
hgbot (developer)
2017-05-10 16:28

Repository: erp/devel/pi
Changeset: 2406203ff921ec475165a8e7ffd1673c6366c30f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 10 16:23:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2406203ff921ec475165a8e7ffd1673c6366c30f [^]

fixes issue 35966: Custom skins for the login page are not working

After the changes introduced on issue 0035386, the loginStyles.css file is requested to load all the styles required for the login page. Since then, as this new file is not included in the modules that provides a new skin, the styles could not be loaded properly.

To avoid this problem in a transparent way, when compiling the loginStyles.css is copied together with the skin resources in the proper location. This file will be a copy of the Openbravo_ERP_250.css file provided by the skin itself.

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
---
(0096522)
hgbot (developer)
2017-05-10 16:42

Repository: erp/devel/pi
Changeset: e3b8444d4afa7fa5ff4619aefece803077c6dbc4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 10 16:41:46 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3b8444d4afa7fa5ff4619aefece803077c6dbc4 [^]

related to issue 35966: improved log message

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
---
(0096595)
alostale (manager)
2017-05-15 13:36

code reviewed + tested
(0096956)
hudsonbot (developer)
2017-05-29 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096957)
hudsonbot (developer)
2017-05-29 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-05-10 10:12 caristu New Issue
2017-05-10 10:12 caristu Assigned To => caristu
2017-05-10 10:12 caristu Modules => Core
2017-05-10 10:12 caristu Regression level => Pre packaging ( pi )
2017-05-10 10:12 caristu Regression date => 2017-04-06
2017-05-10 10:12 caristu Regression introduced in release => pi
2017-05-10 10:12 caristu Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
2017-05-10 10:12 caristu Triggers an Emergency Pack => No
2017-05-10 10:13 caristu Relationship added caused by 0035386
2017-05-10 10:13 caristu Steps to Reproduce Updated View Revisions
2017-05-10 10:13 caristu File Added: loginWrong.png
2017-05-10 10:17 caristu Description Updated View Revisions
2017-05-10 10:19 caristu Summary Custom skins of the login page are not working => Custom skins for the login page are not working
2017-05-10 10:19 caristu Proposed Solution updated
2017-05-10 16:28 hgbot Checkin
2017-05-10 16:28 hgbot Note Added: 0096517
2017-05-10 16:28 hgbot Status new => resolved
2017-05-10 16:28 hgbot Resolution open => fixed
2017-05-10 16:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2406203ff921ec475165a8e7ffd1673c6366c30f [^]
2017-05-10 16:42 hgbot Checkin
2017-05-10 16:42 hgbot Note Added: 0096522
2017-05-10 16:47 caristu Review Assigned To => alostale
2017-05-15 13:36 alostale Note Added: 0096595
2017-05-15 13:36 alostale Status resolved => closed
2017-05-15 13:36 alostale Fixed in Version => 3.0PR17Q3
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096956
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096957


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker