Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0035966Openbravo ERPA. Platformpublic2017-05-10 10:122017-05-29 17:43
caristu 
caristu 
immediateminorN/A
closedfixed 
5
 
3.0PR17Q3 
alostale
Core
Pre packaging ( pi )
2017-04-06
pi
http://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
No
0035966: Custom skins for the login page are not working
After the changes introduced on issue 0035386 the login page skin can not be customized properly.
1) Install the module Skin:Blue
2) Log-in as System Admin and in the [Session Preferences] window, choose the "Blue" skin
3) Log-out. Notice that the styles of the log-in page are missing (see attached image).
The problem is caused because the Login page now uses a new css file (loginStyles.css) which is not present in the expected location that contains the skin resources.
No tags attached.
caused by feature request 0035386 closed caristu Login page needs some clean up 
png loginWrong.png (14,226) 2017-05-10 10:13
https://issues.openbravo.com/file_download.php?file_id=10745&type=bug
png
Issue History
2017-05-10 10:12caristuNew Issue
2017-05-10 10:12caristuAssigned To => caristu
2017-05-10 10:12caristuModules => Core
2017-05-10 10:12caristuRegression level => Pre packaging ( pi )
2017-05-10 10:12caristuRegression date => 2017-04-06
2017-05-10 10:12caristuRegression introduced in release => pi
2017-05-10 10:12caristuRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
2017-05-10 10:12caristuTriggers an Emergency Pack => No
2017-05-10 10:13caristuRelationship addedcaused by 0035386
2017-05-10 10:13caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15141#r15141
2017-05-10 10:13caristuFile Added: loginWrong.png
2017-05-10 10:17caristuDescription Updatedbug_revision_view_page.php?rev_id=15143#r15143
2017-05-10 10:19caristuSummaryCustom skins of the login page are not working => Custom skins for the login page are not working
2017-05-10 10:19caristuProposed Solution updated
2017-05-10 16:28hgbotCheckin
2017-05-10 16:28hgbotNote Added: 0096517
2017-05-10 16:28hgbotStatusnew => resolved
2017-05-10 16:28hgbotResolutionopen => fixed
2017-05-10 16:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2406203ff921ec475165a8e7ffd1673c6366c30f [^]
2017-05-10 16:42hgbotCheckin
2017-05-10 16:42hgbotNote Added: 0096522
2017-05-10 16:47caristuReview Assigned To => alostale
2017-05-15 13:36alostaleNote Added: 0096595
2017-05-15 13:36alostaleStatusresolved => closed
2017-05-15 13:36alostaleFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096956
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096957

Notes
(0096517)
hgbot   
2017-05-10 16:28   
Repository: erp/devel/pi
Changeset: 2406203ff921ec475165a8e7ffd1673c6366c30f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 10 16:23:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2406203ff921ec475165a8e7ffd1673c6366c30f [^]

fixes issue 35966: Custom skins for the login page are not working

After the changes introduced on issue 0035386, the loginStyles.css file is requested to load all the styles required for the login page. Since then, as this new file is not included in the modules that provides a new skin, the styles could not be loaded properly.

To avoid this problem in a transparent way, when compiling the loginStyles.css is copied together with the skin resources in the proper location. This file will be a copy of the Openbravo_ERP_250.css file provided by the skin itself.

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
---
(0096522)
hgbot   
2017-05-10 16:42   
Repository: erp/devel/pi
Changeset: e3b8444d4afa7fa5ff4619aefece803077c6dbc4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 10 16:41:46 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3b8444d4afa7fa5ff4619aefece803077c6dbc4 [^]

related to issue 35966: improved log message

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
---
(0096595)
alostale   
2017-05-15 13:36   
code reviewed + tested
(0096956)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096957)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test