Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035954 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | always | 2017-01-27 15:25 | 2017-05-09 11:05 | |||
| Reporter | psanjuan | View Status | public | |||||
| Assigned To | inigosanchez | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR17Q1.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 1f2d83b1b381 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR17Q1.1 | |||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Professional Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2016-05-24 | |||||||
| Regression introduced in release | 3.0PR16Q3 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/9105dfe33d79e5b7ba39a2680064f7c48c402701 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035954: Fetching data when it is sorting by a null foreign key is not working as expected. | |||||||
| Description | Fetching data when it is sorting by a null foreign key is not working as expected. The problem can be reproduced having a BP with additional identifier (Currency) that is a foreign key and not mandatory (nullable). If currency is null for a BP and data is sorted by BP column, fetching the data is not working as expected. | |||||||
| Steps To Reproduce | - Login as "System Administrator - System" role. - Go to [Module] window and put "Core" module in development mode. - Go to [Tables and Columns] window and select "BusinessPartner" table. - Go to [Column] subtab and open in form view "BP_Currency_ID" record. - Check "Used as Record Identifiew" checkbox. Save it. -Restart tomcat because model has changed. - Login as "F&B International Group Admin" role. - Go to [Business Partner] window and create a new one for testing purposes. [Currency field should be null] - Go to [Location/Address] subtab and create a new test location for the new business partner. - Go to [Sales Order] window and create a new sales order with the BP created in previously steps. - Filter by "Document No." field using the document number generated for the new sales order. [Only the new sales order should be displayed in the grid] - Sort by "Order Date" column and refresh the current data from the toolbar button. Check the record appears. - Sort by "Business Partner" column and refresh the current data from the toolbar button. Check the record disappears. | |||||||
| Proposed Solution | It seems that the reported case is not take into account properly and a inner join is used instead of left join > Review use of useInnerJoinMap map in AdvancedQueryBuilder class. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0096473) hgbot (developer) 2017-05-09 10:07 |
Repository: erp/backports/3.0PR17Q1.1 Changeset: 1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Tue May 09 10:06:09 2017 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec [^] Fixed issue 35954: Fetching data when it is sorting by a null FK is not working Fetching data when it was sorting by a null foreign key was not retrieving any record when should had been retrieved data. When AdvancedQueryBuilder class is created order by clause and it is working in resolve joins a canUseInnerJoin method is invoked. This method is used to check if the left join can be safely replaced with inner join when it is building order by clause. This method is not take into account all the posibilities. The problem has been resolved by take into account when any property of the list is not mandatory and is not primitive. In this case left join can not be replaced with inner join. The rest of the cases can be safely replaced it. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java --- |
|
(0096484) caristu (developer) 2017-05-09 11:05 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-05-09 10:04 | inigosanchez | Type | defect => backport |
| 2017-05-09 10:04 | inigosanchez | Target Version | => 3.0PR17Q1.1 |
| 2017-05-09 10:07 | hgbot | Checkin | |
| 2017-05-09 10:07 | hgbot | Note Added: 0096473 | |
| 2017-05-09 10:07 | hgbot | Status | scheduled => resolved |
| 2017-05-09 10:07 | hgbot | Resolution | open => fixed |
| 2017-05-09 10:07 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/33afd778e515a8e5df2eff4286683edbb7656fec [^] => http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec [^] |
| 2017-05-09 10:09 | inigosanchez | Review Assigned To | => caristu |
| 2017-05-09 11:05 | caristu | Note Added: 0096484 | |
| 2017-05-09 11:05 | caristu | Status | resolved => closed |
| 2017-05-09 11:05 | caristu | Fixed in Version | => 3.0PR17Q1.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |