Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035954Openbravo ERPA. Platformpublic2017-01-27 15:252017-05-09 11:05
Reporterpsanjuan 
Assigned Toinigosanchez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR17Q1.1Fixed in Version3.0PR17Q1.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-05-24
Regression introduced in release3.0PR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/9105dfe33d79e5b7ba39a2680064f7c48c402701 [^]
Triggers an Emergency PackNo
Summary0035954: Fetching data when it is sorting by a null foreign key is not working as expected.
DescriptionFetching data when it is sorting by a null foreign key is not working as expected. The problem can be reproduced having a BP with additional identifier (Currency) that is a foreign key and not mandatory (nullable). If currency is null for a BP and data is sorted by BP column, fetching the data is not working as expected.
Steps To Reproduce- Login as "System Administrator - System" role.
- Go to [Module] window and put "Core" module in development mode.
- Go to [Tables and Columns] window and select "BusinessPartner" table.
- Go to [Column] subtab and open in form view "BP_Currency_ID" record.
- Check "Used as Record Identifiew" checkbox. Save it.
-Restart tomcat because model has changed.

- Login as "F&B International Group Admin" role.
- Go to [Business Partner] window and create a new one for testing purposes. [Currency field should be null]
- Go to [Location/Address] subtab and create a new test location for the new business partner.
- Go to [Sales Order] window and create a new sales order with the BP created in previously steps.
- Filter by "Document No." field using the document number generated for the new sales order. [Only the new sales order should be displayed in the grid]

- Sort by "Order Date" column and refresh the current data from the toolbar button. Check the record appears.
- Sort by "Business Partner" column and refresh the current data from the toolbar button. Check the record disappears.
Proposed SolutionIt seems that the reported case is not take into account properly and a inner join is used instead of left join > Review use of useInnerJoinMap map in AdvancedQueryBuilder class.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035073 closed inigosanchez Fetching data when it is sorting by a null foreign key is not working as expected. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-09 10:04inigosanchezTypedefect => backport
2017-05-09 10:04inigosanchezTarget Version => 3.0PR17Q1.1
2017-05-09 10:07hgbotCheckin
2017-05-09 10:07hgbotNote Added: 0096473
2017-05-09 10:07hgbotStatusscheduled => resolved
2017-05-09 10:07hgbotResolutionopen => fixed
2017-05-09 10:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/33afd778e515a8e5df2eff4286683edbb7656fec [^] => http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec [^]
2017-05-09 10:09inigosanchezReview Assigned To => caristu
2017-05-09 11:05caristuNote Added: 0096484
2017-05-09 11:05caristuStatusresolved => closed
2017-05-09 11:05caristuFixed in Version => 3.0PR17Q1.1

Notes
(0096473)
hgbot   
2017-05-09 10:07   
Repository: erp/backports/3.0PR17Q1.1
Changeset: 1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue May 09 10:06:09 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/1f2d83b1b381af0c8b8cfd3a9930b0f1b78e2dec [^]

Fixed issue 35954: Fetching data when it is sorting by a null FK is not working

Fetching data when it was sorting by a null foreign key was not retrieving any record when should
had been retrieved data.

When AdvancedQueryBuilder class is created order by clause and it is working in resolve joins a
canUseInnerJoin method is invoked. This method is used to check if the left join can be safely
replaced with inner join when it is building order by clause. This method is not take into account
all the posibilities.

The problem has been resolved by take into account when any property of the list is not mandatory
and is not primitive. In this case left join can not be replaced with inner join. The rest of the
cases can be safely replaced it.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0096484)
caristu   
2017-05-09 11:05   
Code reviewed + tested OK.