Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035821 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] StoreServer | minor | have not tried | 2017-04-20 10:19 | 2017-06-09 21:09 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | no change required | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR17Q2.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035821: MobileServerUtils: Incorrectly comparing string values using != instead of equals method | |||||||
| Description | See the code here [1] it does this: if (p.getClient().getId() != "0" || p.getOrganization().getId() != "0") { However comparing strings like this is wrong, equals should be used: if (!"0".equals(p.getClient().getId()) || !"0".equals(p.getOrganization().getId())) { Bug was introduced by this commit [2] [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/44e8f0f349dc/src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java#l116 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dc#l1.43 [^] | |||||||
| Steps To Reproduce | Check the code | |||||||
| Proposed Solution | use equals, as proposed in the description | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-24 17:30 | mtaal | Type | defect => backport |
| 2017-04-24 17:30 | mtaal | Target Version | RR17Q3 => RR17Q2.1 |
| 2017-06-09 21:09 | mtaal | Note Added: 0097295 | |
| 2017-06-09 21:09 | mtaal | Status | scheduled => closed |
| 2017-06-09 21:09 | mtaal | Resolution | open => no change required |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |