0035821: MobileServerUtils: Incorrectly comparing string values using != instead of equals method

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035821

Retail Modules

StoreServer

public

2017-04-20 10:19

2017-06-09 21:09

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

Target Version

RR17Q2.1

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035821: MobileServerUtils: Incorrectly comparing string values using != instead of equals method

Description

See the code here [1] it does this:
if (p.getClient().getId() != "0" || p.getOrganization().getId() != "0") {

However comparing strings like this is wrong, equals should be used:
if (!"0".equals(p.getClient().getId()) || !"0".equals(p.getOrganization().getId())) {

Bug was introduced by this commit [2]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/44e8f0f349dc/src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java#l116 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dc#l1.43 [^]

Steps To Reproduce

Check the code

Proposed Solution

use equals, as proposed in the description

Additional Information