Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035687 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2017-04-04 16:13 | 2017-04-10 13:08 | |||
| Reporter | inigosanchez | View Status | public | |||||
| Assigned To | platform | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | fe5b3c2195c9 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR17Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2016-09-14 | |||||||
| Regression introduced in release | 3.0PR17Q1 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035687: It is not possible to delete a record in tree view | |||||||
| Description | It is not possible to delete a record in tree view. An error is thrown in console: ISC_Combined.js:1410 Uncaught RangeError: Maximum call stack size exceeded at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003) at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002) at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003) at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002) at _2.isc_c_Comm__cloneArray [as $361] (ISC_Combined.js:3002) at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3001) at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003) at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002) at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003) at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002) | |||||||
| Steps To Reproduce | - Log in as F&B International Group Admin - Go to [Account Tree] window. - Select "F&B International Group" record and go to [Element Value] subtab. - Open tree view by clicking in "Toggle Tree Grid Visibility" button. - Open PL | Profit & Loss node and select leaf node: Total Other Income (Expense). Delete it. Note than leaf node is not removed properly. An error is thrown in console. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0095902) hgbot (developer) 2017-04-07 11:56 |
Repository: erp/backports/3.0PR17Q2 Changeset: fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Fri Apr 07 11:55:48 2017 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef [^] Fixed issue 35687: It is not possible to delete a record in tree view The problem was related with Pre Delete Client Side Event Handler. The problem was that a isc.clone method didn't work as expected. isc.clone method create a deep clone of an object that can be edited without affecting the original but does not handle looping references (will infinite loop). For this reason, in case of clone currentGrid.getSelection() object in tree view an error was thrown. In order to fix this problem, isc.shallowClone is used instead of isc.clone. This method handle looping references properly. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0095933) caristu (developer) 2017-04-10 13:08 |
Code review + testing OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-04 16:15 | inigosanchez | Type | defect => backport |
| 2017-04-04 16:15 | inigosanchez | Target Version | => 3.0PR17Q2 |
| 2017-04-07 11:44 | inigosanchez | Review Assigned To | => caristu |
| 2017-04-07 11:56 | hgbot | Checkin | |
| 2017-04-07 11:56 | hgbot | Note Added: 0095902 | |
| 2017-04-07 11:56 | hgbot | Status | scheduled => resolved |
| 2017-04-07 11:56 | hgbot | Resolution | open => fixed |
| 2017-04-07 11:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef [^] |
| 2017-04-10 13:08 | caristu | Note Added: 0095933 | |
| 2017-04-10 13:08 | caristu | Status | resolved => closed |
| 2017-04-10 13:08 | caristu | Fixed in Version | => 3.0PR17Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |