Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035687Openbravo ERPA. Platformpublic2017-04-04 16:132017-04-10 13:08
Reporterinigosanchez 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q2Fixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2016-09-14
Regression introduced in release3.0PR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^]
Triggers an Emergency PackNo
Summary0035687: It is not possible to delete a record in tree view
DescriptionIt is not possible to delete a record in tree view. An error is thrown in console:
ISC_Combined.js:1410 Uncaught RangeError: Maximum call stack size exceeded
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneArray [as $361] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3001)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
Steps To Reproduce- Log in as F&B International Group Admin
- Go to [Account Tree] window.
- Select "F&B International Group" record and go to [Element Value] subtab.
- Open tree view by clicking in "Toggle Tree Grid Visibility" button.
- Open PL | Profit & Loss node and select leaf node: Total Other Income (Expense). Delete it.

Note than leaf node is not removed properly. An error is thrown in console.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035686 closed inigosanchez It is not possible to delete a record in tree view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-04 16:15inigosanchezTypedefect => backport
2017-04-04 16:15inigosanchezTarget Version => 3.0PR17Q2
2017-04-07 11:44inigosanchezReview Assigned To => caristu
2017-04-07 11:56hgbotCheckin
2017-04-07 11:56hgbotNote Added: 0095902
2017-04-07 11:56hgbotStatusscheduled => resolved
2017-04-07 11:56hgbotResolutionopen => fixed
2017-04-07 11:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef [^]
2017-04-10 13:08caristuNote Added: 0095933
2017-04-10 13:08caristuStatusresolved => closed
2017-04-10 13:08caristuFixed in Version => 3.0PR17Q2

Notes
(0095902)
hgbot   
2017-04-07 11:56   
Repository: erp/backports/3.0PR17Q2
Changeset: fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Apr 07 11:55:48 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q2/rev/fe5b3c2195c9f7b2b067c6e8282bb37b7d530fef [^]

Fixed issue 35687: It is not possible to delete a record in tree view

The problem was related with Pre Delete Client Side Event Handler. The problem
was that a isc.clone method didn't work as expected. isc.clone method create a
deep clone of an object that can be edited without affecting the original but
does not handle looping references (will infinite loop). For this reason, in
case of clone currentGrid.getSelection() object in tree view an error was thrown.

In order to fix this problem, isc.shallowClone is used instead of isc.clone. This
method handle looping references properly.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0095933)
caristu   
2017-04-10 13:08   
Code review + testing OK.