Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035686
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-04-04 16:132017-05-29 17:43
ReporterinigosanchezView Statuspublic 
Assigned Toinigosanchez 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revisioncd1ddeb9938d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2016-09-14
Regression introduced in release3.0PR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^]
Triggers an Emergency PackNo
Summary

0035686: It is not possible to delete a record in tree view

DescriptionIt is not possible to delete a record in tree view. An error is thrown in console:
ISC_Combined.js:1410 Uncaught RangeError: Maximum call stack size exceeded
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneArray [as $361] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3001)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
    at _2.isc_c_Comm__cloneObject [as $362] (ISC_Combined.js:3003)
    at _2.isc_c_Comm__clone [as $360] (ISC_Combined.js:3002)
Steps To Reproduce- Log in as F&B International Group Admin
- Go to [Account Tree] window.
- Select "F&B International Group" record and go to [Element Value] subtab.
- Open tree view by clicking in "Toggle Tree Grid Visibility" button.
- Open PL | Profit & Loss node and select leaf node: Total Other Income (Expense). Delete it.

Note than leaf node is not removed properly. An error is thrown in console.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00356873.0PR17Q2 closedplatform It is not possible to delete a record in tree view 
depends on backport 00356883.0PR17Q1.1 closedinigosanchez It is not possible to delete a record in tree view 
caused by feature request 0033976 closedplatform Implement Client Side Event Handler Pre Delete Action 

-  Notes
(0095895)
inigosanchez (developer)
2017-04-07 11:28
edited on: 2017-04-07 11:54

 Added a test in testlink: Platform > [TGV] Tree Grid View > [TGVc] Custom Tree Structure > TGVc020 remove tree nodes

Manual test in account tree:
- Remove an element in tree view.
- Remove an element in grid view.
- Remove two elements in tree view.
- Remove two elements in grid view.
(0095896)
hgbot (developer)
2017-04-07 11:35

 Repository: erp/devel/pi
Changeset: cd1ddeb9938d10689ab7a7930926091b3b5d2d2f
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Apr 07 11:33:44 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cd1ddeb9938d10689ab7a7930926091b3b5d2d2f [^]

Fixed issue 35686: It is not possible to delete a record in tree view

The problem was related with Pre Delete Client Side Event Handler. The problem was
that a isc.clone method didn't work as expected. isc.clone method create a deep
clone of an object that can be edited without affecting the original but does not
handle looping references (will infinite loop). For this reason, in case of clone
currentGrid.getSelection() object in tree view an error was thrown.

In order to fix this problem, isc.shallowClone is used instead of isc.clone. This
method handle looping references properly.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0095931)
caristu (developer)
2017-04-10 13:06

 Code review + testing OK.
(0096871)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-04-04 16:13 inigosanchez New Issue
2017-04-04 16:13 inigosanchez Assigned To => platform
2017-04-04 16:13 inigosanchez Modules => Core
2017-04-04 16:13 inigosanchez Regression level => Production - QA Approved
2017-04-04 16:13 inigosanchez Regression date => 2016-09-14
2017-04-04 16:13 inigosanchez Regression introduced in release => 3.0PR17Q1
2017-04-04 16:13 inigosanchez Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^]
2017-04-04 16:13 inigosanchez Triggers an Emergency Pack => No
2017-04-04 16:15 inigosanchez Status new => scheduled
2017-04-04 16:15 inigosanchez Assigned To platform => inigosanchez
2017-04-04 16:23 inigosanchez Relationship added caused by 0033976
2017-04-07 09:47 inigosanchez Review Assigned To => caristu
2017-04-07 11:28 inigosanchez Note Added: 0095895
2017-04-07 11:30 inigosanchez Note Edited: 0095895 View Revisions
2017-04-07 11:35 hgbot Checkin
2017-04-07 11:35 hgbot Note Added: 0095896
2017-04-07 11:35 hgbot Status scheduled => resolved
2017-04-07 11:35 hgbot Resolution open => fixed
2017-04-07 11:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cd1ddeb9938d10689ab7a7930926091b3b5d2d2f [^]
2017-04-07 11:54 inigosanchez Note Edited: 0095895 View Revisions
2017-04-10 13:06 caristu Note Added: 0095931
2017-04-10 13:06 caristu Status resolved => closed
2017-04-10 13:06 caristu Fixed in Version => 3.0PR17Q3
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096871

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker