Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035544
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2017-03-16 16:412017-04-10 09:55
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revisionb7bd806f8ab4
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration

DescriptionDeleting a line with associated services raises a message saying "Cannot calculate receipt taxes dodivide(): Divide by 0"
Steps To Reproduce* Configure web pos with the preference "Web POS Save Removed Tickets" activated
* Add two units of a product grouped
* Add a service to this product: This service has to be linked to the previous product, configured with quantity as per product and not grouped. Then two lines with quantity 1 of the service will be added linked to the first line of the product that has quantity 2.
* Select the first product added and delete the line.
* The error is raised "Cannot calculate receipt taxes dodivide(): Divide by 0"
Proposed SolutionApply thia changeset: https://code.openbravo.com/retail/try/org.openbravo.retail.posterminal/rev/546c66b22f60 [^]
It has been in the try job: https://ci.openbravo.com/view/try-retail/job/try-ret-init/7669 [^] The failures in this job are not related to the changeset
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035741 closedasiermartirena Deleted lines are not correctly stored in backend 

-  Notes
(0095826)
hgbot (developer)
2017-04-04 17:14

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 72af270f7bebba34039893f2545fc32174ca9df3
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Apr 04 17:12:19 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Protected taxes calculation when qty = 0. This is the situation when saving deleted lines, the qty is set to zero

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0095840)
hgbot (developer)
2017-04-05 09:39

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dd42ff76e7aef8c1a5d9b047056df393b5d8a284
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 05 09:36:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd42ff76e7aef8c1a5d9b047056df393b5d8a284 [^]

Issue 35544 Backed out changeset 72af270f7beb

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0095897)
hgbot (developer)
2017-04-07 11:36

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2bc041afdd5e9b83f8670f92ff1c18eabf088af9
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 05 13:35:29 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095898)
hgbot (developer)
2017-04-07 11:36

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c380eed9a96e360ba2fe40460d542b4972806ba4
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 11:48:28 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Fixes a test failing in an undo command

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0095899)
hgbot (developer)
2017-04-07 11:37

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 13:12:19 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Adjusts tax id for deleted lines if removed previously

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095901)
hgbot (developer)
2017-04-07 11:37

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 23:17:23 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Adjustments in undo when deleting line

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095921)
hgbot (developer)
2017-04-07 22:15

 Repository: tools/automation/pi-mobile
Changeset: 23c0fa48489bb139098d7bef0c03291355adcf5d
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Apr 07 10:42:20 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/23c0fa48489bb139098d7bef0c03291355adcf5d [^]

Verifies issue 35544: Added automated test 'I35544_ServiceDeleteLineDivideZero'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/I35544_ServiceDeleteLineDivideZero.java
---

- Issue History
Date Modified Username Field Change
2017-03-16 16:41 adrianromero New Issue
2017-03-16 16:41 adrianromero Assigned To => Retail
2017-03-16 16:41 adrianromero Resolution time => 1490824800
2017-03-16 16:41 adrianromero Triggers an Emergency Pack => No
2017-03-16 16:41 adrianromero Tag Attached: SER-QA
2017-03-16 17:48 adrianromero Proposed Solution updated
2017-03-17 09:48 migueldejuana Assigned To Retail => migueldejuana
2017-03-17 09:49 migueldejuana Status new => scheduled
2017-03-17 10:15 migueldejuana Assigned To migueldejuana => adrianromero
2017-03-22 11:14 adrianromero Proposed Solution updated
2017-03-31 14:20 adrianromero Proposed Solution updated
2017-04-04 17:14 hgbot Checkin
2017-04-04 17:14 hgbot Note Added: 0095826
2017-04-04 17:14 hgbot Status scheduled => resolved
2017-04-04 17:14 hgbot Resolution open => fixed
2017-04-04 17:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^]
2017-04-05 09:39 hgbot Checkin
2017-04-05 09:39 hgbot Note Added: 0095840
2017-04-05 09:39 adrianromero Status resolved => new
2017-04-05 09:39 adrianromero Resolution fixed => open
2017-04-07 11:36 hgbot Checkin
2017-04-07 11:36 hgbot Note Added: 0095897
2017-04-07 11:36 hgbot Status new => resolved
2017-04-07 11:36 hgbot Resolution open => fixed
2017-04-07 11:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^]
2017-04-07 11:36 hgbot Checkin
2017-04-07 11:36 hgbot Note Added: 0095898
2017-04-07 11:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^]
2017-04-07 11:37 hgbot Checkin
2017-04-07 11:37 hgbot Note Added: 0095899
2017-04-07 11:37 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^]
2017-04-07 11:37 hgbot Checkin
2017-04-07 11:37 hgbot Note Added: 0095901
2017-04-07 11:37 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af [^]
2017-04-07 22:15 hgbot Checkin
2017-04-07 22:15 hgbot Note Added: 0095921
2017-04-10 09:55 marvintm Review Assigned To => marvintm
2017-04-10 09:55 marvintm Status resolved => closed
2017-04-10 09:55 marvintm Fixed in Version => RR17Q3
2017-04-18 10:20 adrianromero Relationship added related to 0035741

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker