Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035544Retail ModulesWeb POSpublic2017-03-16 16:412017-04-10 09:55
Reporteradrianromero 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
DescriptionDeleting a line with associated services raises a message saying "Cannot calculate receipt taxes dodivide(): Divide by 0"
Steps To Reproduce* Configure web pos with the preference "Web POS Save Removed Tickets" activated
* Add two units of a product grouped
* Add a service to this product: This service has to be linked to the previous product, configured with quantity as per product and not grouped. Then two lines with quantity 1 of the service will be added linked to the first line of the product that has quantity 2.
* Select the first product added and delete the line.
* The error is raised "Cannot calculate receipt taxes dodivide(): Divide by 0"
Proposed SolutionApply thia changeset: https://code.openbravo.com/retail/try/org.openbravo.retail.posterminal/rev/546c66b22f60 [^]
It has been in the try job: https://ci.openbravo.com/view/try-retail/job/try-ret-init/7669 [^] The failures in this job are not related to the changeset
Additional Information
TagsSER-QA
Relationships
related to defect 0035741 closed asiermartirena Deleted lines are not correctly stored in backend 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-16 16:41adrianromeroNew Issue
2017-03-16 16:41adrianromeroAssigned To => Retail
2017-03-16 16:41adrianromeroResolution time => 1490824800
2017-03-16 16:41adrianromeroTriggers an Emergency Pack => No
2017-03-16 16:41adrianromeroTag Attached: SER-QA
2017-03-16 17:48adrianromeroProposed Solution updated
2017-03-17 09:48migueldejuanaAssigned ToRetail => migueldejuana
2017-03-17 09:49migueldejuanaStatusnew => scheduled
2017-03-17 10:15migueldejuanaAssigned Tomigueldejuana => adrianromero
2017-03-22 11:14adrianromeroProposed Solution updated
2017-03-31 14:20adrianromeroProposed Solution updated
2017-04-04 17:14hgbotCheckin
2017-04-04 17:14hgbotNote Added: 0095826
2017-04-04 17:14hgbotStatusscheduled => resolved
2017-04-04 17:14hgbotResolutionopen => fixed
2017-04-04 17:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^]
2017-04-05 09:39hgbotCheckin
2017-04-05 09:39hgbotNote Added: 0095840
2017-04-05 09:39adrianromeroStatusresolved => new
2017-04-05 09:39adrianromeroResolutionfixed => open
2017-04-07 11:36hgbotCheckin
2017-04-07 11:36hgbotNote Added: 0095897
2017-04-07 11:36hgbotStatusnew => resolved
2017-04-07 11:36hgbotResolutionopen => fixed
2017-04-07 11:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^]
2017-04-07 11:36hgbotCheckin
2017-04-07 11:36hgbotNote Added: 0095898
2017-04-07 11:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^]
2017-04-07 11:37hgbotCheckin
2017-04-07 11:37hgbotNote Added: 0095899
2017-04-07 11:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^]
2017-04-07 11:37hgbotCheckin
2017-04-07 11:37hgbotNote Added: 0095901
2017-04-07 11:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af [^]
2017-04-07 22:15hgbotCheckin
2017-04-07 22:15hgbotNote Added: 0095921
2017-04-10 09:55marvintmReview Assigned To => marvintm
2017-04-10 09:55marvintmStatusresolved => closed
2017-04-10 09:55marvintmFixed in Version => RR17Q3
2017-04-18 10:20adrianromeroRelationship addedrelated to 0035741

Notes
(0095826)
hgbot   
2017-04-04 17:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 72af270f7bebba34039893f2545fc32174ca9df3
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Apr 04 17:12:19 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72af270f7bebba34039893f2545fc32174ca9df3 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Protected taxes calculation when qty = 0. This is the situation when saving deleted lines, the qty is set to zero

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0095840)
hgbot   
2017-04-05 09:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dd42ff76e7aef8c1a5d9b047056df393b5d8a284
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 05 09:36:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd42ff76e7aef8c1a5d9b047056df393b5d8a284 [^]

Issue 35544 Backed out changeset 72af270f7beb

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0095897)
hgbot   
2017-04-07 11:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2bc041afdd5e9b83f8670f92ff1c18eabf088af9
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Apr 05 13:35:29 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2bc041afdd5e9b83f8670f92ff1c18eabf088af9 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095898)
hgbot   
2017-04-07 11:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c380eed9a96e360ba2fe40460d542b4972806ba4
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 11:48:28 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c380eed9a96e360ba2fe40460d542b4972806ba4 [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Fixes a test failing in an undo command

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0095899)
hgbot   
2017-04-07 11:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 13:12:19 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/816c40dbb8e2a26cd0ac8b28b9d0f12cb98e286d [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Adjusts tax id for deleted lines if removed previously

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095901)
hgbot   
2017-04-07 11:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Apr 06 23:17:23 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b7bd806f8ab48f6e70ba0e2a8acb4dadf65174af [^]

Fixes issue 0035544: [SER-QA 2610] Divide by 0 error in taxes calculation when deleting a line in a receipt with an especial configuration
* Adjustments in undo when deleting line

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0095921)
hgbot   
2017-04-07 22:15   
Repository: tools/automation/pi-mobile
Changeset: 23c0fa48489bb139098d7bef0c03291355adcf5d
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Apr 07 10:42:20 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/23c0fa48489bb139098d7bef0c03291355adcf5d [^]

Verifies issue 35544: Added automated test 'I35544_ServiceDeleteLineDivideZero'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/I35544_ServiceDeleteLineDivideZero.java
---