Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035443

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

feature request

[Retail Modules] Web POS

minor

N/A

2017-03-07 12:42

2017-03-24 12:34

Reporter

guillermogil

View Status

public

Assigned To

migueldejuana

Priority

normal

Resolution

fixed

Fixed in Version

RR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035443: OBPOS_PreDeleteLine Hook cannot be cancelled

Description

OBPOS_PreDeleteLine Hook cannot be cancelled, it has no return parameter.
With the current behavior it is not possible to stop the deletion of a line based on several conditions trough a custom module.

Steps To Reproduce

N/A

Proposed Solution

Add an args.cancellation to the hook

Tags

No tags attached.

issue35443.commit [^] (1,110 bytes) 2017-03-16 11:38

issue35443_16Q4.diff [^] (758 bytes) 2017-03-20 16:49 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
@@ -872,7 +872,10 @@
       OB.UTIL.HookManager.executeHooks('OBPOS_PreDeleteLine', {
         order: receipt,
         selectedLines: selectedModels
-      }, function () {
+      }, function (args) {
+        if (args && args.cancelOperation && args.cancelOperation === true) {
+          return;
+        }
         enyo.$.scrim.show();
         receipt.get('lines').forEach(function (line, idx) {
           line.set('undoPosition', idx);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0035392		closed	ranjith_qualiantech_com	[SERQA 2515] Wrong quantity for services defined as grouped product=No and Quantity Rule=As per product
depends on	defect	0035444		closed	migueldejuana	DeleteLine logic is duplicated across several functionalities

Notes
(0095320) hgbot (developer) 2017-03-16 13:31	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c4caecd017f43a04d8e3f86b7be7c957d1658db9 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Mar 10 12:36:29 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4caecd017f43a04d8e3f86b7be7c957d1658db9 [^] Fixed issue 0035443: OBPOS_PreDeleteLine Hook cannot be cancelled - Add the posibility of cancel the execution --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js ---

Issue History
Date Modified	Username	Field	Change
2017-03-07 12:42	guillermogil	New Issue
2017-03-07 12:42	guillermogil	Assigned To	=> Retail
2017-03-07 12:42	guillermogil	OBNetwork customer	=> Yes
2017-03-07 12:42	guillermogil	Resolution time	=> 1490652000
2017-03-07 12:42	guillermogil	Triggers an Emergency Pack	=> No
2017-03-07 12:49	guillermogil	Relationship added	depends on 0035444
2017-03-08 10:14	migueldejuana	Assigned To	Retail => migueldejuana
2017-03-08 10:14	migueldejuana	Status	new => scheduled
2017-03-09 13:33	migueldejuana	Relationship added	related to 0035392
2017-03-16 11:38	migueldejuana	File Added: issue35443.commit
2017-03-16 13:31	hgbot	Checkin
2017-03-16 13:31	hgbot	Note Added: 0095320
2017-03-16 13:31	hgbot	Status	scheduled => resolved
2017-03-16 13:31	hgbot	Resolution	open => fixed
2017-03-16 13:31	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4caecd017f43a04d8e3f86b7be7c957d1658db9 [^]
2017-03-20 16:49	migueldejuana	File Added: issue35443_16Q4.diff
2017-03-24 12:34	marvintm	Review Assigned To	=> marvintm
2017-03-24 12:34	marvintm	Status	resolved => closed
2017-03-24 12:34	marvintm	Fixed in Version	=> RR17Q2

Copyright © 2000 - 2009 MantisBT Group