Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035443Retail ModulesWeb POSpublic2017-03-07 12:422017-03-24 12:34
Reporterguillermogil 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035443: OBPOS_PreDeleteLine Hook cannot be cancelled
DescriptionOBPOS_PreDeleteLine Hook cannot be cancelled, it has no return parameter.
With the current behavior it is not possible to stop the deletion of a line based on several conditions trough a custom module.
Steps To ReproduceN/A
Proposed SolutionAdd an args.cancellation to the hook
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035392 closed ranjith_qualiantech_com [SERQA 2515] Wrong quantity for services defined as grouped product=No and Quantity Rule=As per product 
depends on defect 0035444 closed migueldejuana DeleteLine logic is duplicated across several functionalities 
Attached Files? issue35443.commit (1,110) 2017-03-16 11:38
https://issues.openbravo.com/file_download.php?file_id=10577&type=bug
diff issue35443_16Q4.diff (758) 2017-03-20 16:49
https://issues.openbravo.com/file_download.php?file_id=10586&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-07 12:42guillermogilNew Issue
2017-03-07 12:42guillermogilAssigned To => Retail
2017-03-07 12:42guillermogilOBNetwork customer => Yes
2017-03-07 12:42guillermogilResolution time => 1490652000
2017-03-07 12:42guillermogilTriggers an Emergency Pack => No
2017-03-07 12:49guillermogilRelationship addeddepends on 0035444
2017-03-08 10:14migueldejuanaAssigned ToRetail => migueldejuana
2017-03-08 10:14migueldejuanaStatusnew => scheduled
2017-03-09 13:33migueldejuanaRelationship addedrelated to 0035392
2017-03-16 11:38migueldejuanaFile Added: issue35443.commit
2017-03-16 13:31hgbotCheckin
2017-03-16 13:31hgbotNote Added: 0095320
2017-03-16 13:31hgbotStatusscheduled => resolved
2017-03-16 13:31hgbotResolutionopen => fixed
2017-03-16 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4caecd017f43a04d8e3f86b7be7c957d1658db9 [^]
2017-03-20 16:49migueldejuanaFile Added: issue35443_16Q4.diff
2017-03-24 12:34marvintmReview Assigned To => marvintm
2017-03-24 12:34marvintmStatusresolved => closed
2017-03-24 12:34marvintmFixed in Version => RR17Q2

Notes
(0095320)
hgbot   
2017-03-16 13:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c4caecd017f43a04d8e3f86b7be7c957d1658db9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Mar 10 12:36:29 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4caecd017f43a04d8e3f86b7be7c957d1658db9 [^]

Fixed issue 0035443: OBPOS_PreDeleteLine Hook cannot be cancelled

- Add the posibility of cancel the execution

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---