Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034725
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformmajorsometimes2016-12-13 13:392016-12-20 16:32
ReportervmromanosView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision520a0bb991a6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034725: BaseProcessActionHandler: jrParams needed inside getReportData() method

DescriptionIt would be useful to receive the UI report definition parameters inside the getReportData() method.
Right now the only way to do it is to override the doExecute() method to add these parameters to the map.
Steps To ReproduceNA
Proposed SolutionSeveral solutions proposed:

1. Attached solution doesn't imply an API change.
Note that it should be necessary only adding the "jrParams" to the parameters map, since the loadFilterParams() method already copies the params info to jrParams


2. Modify (or add a new method) getReportData to receive the parameters and jrParams.
This is solution is more clear but requires an API change.
TagsNo tags attached.
Attached Filesdiff file icon BaseReportActionHandler.diff [^] (1,404 bytes) 2016-12-13 13:39 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0026763 closedgorkaion Ability to launch reports from process definitions 

-  Notes
(0092370)
hgbot (developer)
2016-12-14 16:47

 Repository: erp/devel/pi
Changeset: 520a0bb991a6acaaf4c3394a751471fa52b57676
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Dec 14 16:45:26 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/520a0bb991a6acaaf4c3394a751471fa52b57676 [^]

fixes issue 34725: make jasper report params accessible in getReportData method

Now the parameter map received as an argument in getReportData() contains the HTTP request parameters together with the parameters that will be sent to the report. This second set of parameters can be retrieved from the map using the JASPER_REPORT_PARAMETERS key

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
---
(0092460)
alostale (manager)
2016-12-16 09:05

 reopening due to code review:
https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0092462)
hgbot (developer)
2016-12-16 09:15

 Repository: erp/devel/pi
Changeset: 93f6391178a1ea606999429667c88272e3f66e8b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Dec 16 09:12:21 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/93f6391178a1ea606999429667c88272e3f66e8b [^]

related to issue 34725: define maps using Map class

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
---
(0092463)
alostale (manager)
2016-12-16 09:19

 code reviewed
(0092477)
caristu (developer)
2016-12-16 11:58

 Updated wiki page: http://wiki.openbravo.com/wiki/How_to_create_a_Report_using_Process_Definition#Report_Datasource_Definition [^]
(0092713)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092724)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-12-13 13:39 vmromanos New Issue
2016-12-13 13:39 vmromanos Assigned To => caristu
2016-12-13 13:39 vmromanos File Added: BaseReportActionHandler.diff
2016-12-13 13:39 vmromanos Modules => Core
2016-12-13 13:39 vmromanos Triggers an Emergency Pack => No
2016-12-13 17:30 caristu Status new => scheduled
2016-12-14 16:47 hgbot Checkin
2016-12-14 16:47 hgbot Note Added: 0092370
2016-12-14 16:47 hgbot Status scheduled => resolved
2016-12-14 16:47 hgbot Resolution open => fixed
2016-12-14 16:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/520a0bb991a6acaaf4c3394a751471fa52b57676 [^]
2016-12-14 16:53 caristu Review Assigned To => alostale
2016-12-16 09:05 alostale Note Added: 0092460
2016-12-16 09:05 alostale Status resolved => new
2016-12-16 09:05 alostale Resolution fixed => open
2016-12-16 09:15 hgbot Checkin
2016-12-16 09:15 hgbot Note Added: 0092462
2016-12-16 09:19 alostale Status new => scheduled
2016-12-16 09:19 alostale Status scheduled => resolved
2016-12-16 09:19 alostale Resolution open => fixed
2016-12-16 09:19 alostale Note Added: 0092463
2016-12-16 09:19 alostale Status resolved => closed
2016-12-16 09:19 alostale Fixed in Version => 3.0PR17Q1
2016-12-16 11:58 caristu Note Added: 0092477
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092713
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092724
2016-12-20 16:32 caristu Relationship added related to 0026763

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker