Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034725Openbravo ERPA. Platformpublic2016-12-13 13:392016-12-20 16:32
Reportervmromanos 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034725: BaseProcessActionHandler: jrParams needed inside getReportData() method
DescriptionIt would be useful to receive the UI report definition parameters inside the getReportData() method.
Right now the only way to do it is to override the doExecute() method to add these parameters to the map.
Steps To ReproduceNA
Proposed SolutionSeveral solutions proposed:

1. Attached solution doesn't imply an API change.
Note that it should be necessary only adding the "jrParams" to the parameters map, since the loadFilterParams() method already copies the params info to jrParams


2. Modify (or add a new method) getReportData to receive the parameters and jrParams.
This is solution is more clear but requires an API change.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0026763 closed gorkaion Ability to launch reports from process definitions 
Attached Filesdiff BaseReportActionHandler.diff (1,404) 2016-12-13 13:39
https://issues.openbravo.com/file_download.php?file_id=10167&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-12-13 13:39vmromanosNew Issue
2016-12-13 13:39vmromanosAssigned To => caristu
2016-12-13 13:39vmromanosFile Added: BaseReportActionHandler.diff
2016-12-13 13:39vmromanosModules => Core
2016-12-13 13:39vmromanosTriggers an Emergency Pack => No
2016-12-13 17:30caristuStatusnew => scheduled
2016-12-14 16:47hgbotCheckin
2016-12-14 16:47hgbotNote Added: 0092370
2016-12-14 16:47hgbotStatusscheduled => resolved
2016-12-14 16:47hgbotResolutionopen => fixed
2016-12-14 16:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/520a0bb991a6acaaf4c3394a751471fa52b57676 [^]
2016-12-14 16:53caristuReview Assigned To => alostale
2016-12-16 09:05alostaleNote Added: 0092460
2016-12-16 09:05alostaleStatusresolved => new
2016-12-16 09:05alostaleResolutionfixed => open
2016-12-16 09:15hgbotCheckin
2016-12-16 09:15hgbotNote Added: 0092462
2016-12-16 09:19alostaleStatusnew => scheduled
2016-12-16 09:19alostaleStatusscheduled => resolved
2016-12-16 09:19alostaleResolutionopen => fixed
2016-12-16 09:19alostaleNote Added: 0092463
2016-12-16 09:19alostaleStatusresolved => closed
2016-12-16 09:19alostaleFixed in Version => 3.0PR17Q1
2016-12-16 11:58caristuNote Added: 0092477
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092713
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092724
2016-12-20 16:32caristuRelationship addedrelated to 0026763

Notes
(0092370)
hgbot   
2016-12-14 16:47   
Repository: erp/devel/pi
Changeset: 520a0bb991a6acaaf4c3394a751471fa52b57676
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Dec 14 16:45:26 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/520a0bb991a6acaaf4c3394a751471fa52b57676 [^]

fixes issue 34725: make jasper report params accessible in getReportData method

Now the parameter map received as an argument in getReportData() contains the HTTP request parameters together with the parameters that will be sent to the report. This second set of parameters can be retrieved from the map using the JASPER_REPORT_PARAMETERS key

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
---
(0092460)
alostale   
2016-12-16 09:05   
reopening due to code review:
https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0092462)
hgbot   
2016-12-16 09:15   
Repository: erp/devel/pi
Changeset: 93f6391178a1ea606999429667c88272e3f66e8b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Dec 16 09:12:21 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/93f6391178a1ea606999429667c88272e3f66e8b [^]

related to issue 34725: define maps using Map class

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
---
(0092463)
alostale   
2016-12-16 09:19   
code reviewed
(0092477)
caristu   
2016-12-16 11:58   
Updated wiki page: http://wiki.openbravo.com/wiki/How_to_create_a_Report_using_Process_Definition#Report_Datasource_Definition [^]
(0092713)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092724)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test