Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034709
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2016-09-13 11:442016-12-12 10:22
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR16Q3.4
StatusclosedFix in branchFixed in SCM revisiona467233e6f4d
ProjectionnoneETAnoneTarget VersionRR16Q3.4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034709: Keeping track of deleted tickets is generating incorrect data

DescriptionSince 16Q2, it is possible to configure the Openbravo instance so that relevant deleted tickets are synchronized to the backend:

http://wiki.openbravo.com/wiki/Projects:Keep_Track_Of_Deleted_Ticket_Lines [^]

The idea is that these tickets would be changed so that their ordered quantity is set to zero. This works correctly, but there are several parts of the ticket which should be changed, and currently are not being set correctly. Specifically:

- Taxes (at both document and line level) should be zero, and currently are not.
- Totals at line level (both net and gross) should be zero, and currently are not.
- Discount information should also be discussed.

Steps To Reproduce- Activate the functionality to keep track of deleted tickets, creating a preference for property "Web POS Save Removed Tickets"
- Create a ticket in the Web POS. Add some lines to it.
- Delete the ticket via the "Delete ticket" button.
- Check the ticket in the backend, and verify that tax information is not empty, and line totals are not zero.
Proposed SolutionCurrently there is code in the OrderLoader that zeroes the totals of the header, and also the quantity of the lines. I believe a better approach would be to change the functionality so that the ticket in the client side is modified, by setting the quantity of each line to zero, and then recomputing the ticket using the existing calculateReceipt function in the client side.

In this way, the code would be much cleaner, the OrderLoader would not need to even know about the functionality, and would just save the modified ticket as it is.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0033961 closedasiermartirena Keeping track of deleted tickets is generating incorrect data 

-  Notes
(0092210)
hgbot (developer)
2016-12-08 10:17

 Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal
Changeset: a467233e6f4d2eb238ab0286fb51e1c0c298caa7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 08 14:42:24 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/a467233e6f4d2eb238ab0286fb51e1c0c298caa7 [^]

Fixes issue 34709 : Validated line quantity if the Save Remove ticket preference is enabled

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092211)
hgbot (developer)
2016-12-08 10:17

 Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.discounts
Changeset: 041e1f1eeaec9201d7ca1b9587f71e3176818f61
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 08 14:29:07 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.discounts/rev/041e1f1eeaec9201d7ca1b9587f71e3176818f61 [^]

Related to issue 34709 : Validate line with quantity 0 while calculating promotion

---
M web/org.openbravo.retail.discounts/js/promotion-discount.js
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0092212)
hgbot (developer)
2016-12-08 10:17

 Repository: retail/backports/3.0RR16Q3.4/pi-mobile
Changeset: f1946e2771f870825ace14ee5787d6900ba8fa7d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 08 14:29:16 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/pi-mobile/rev/f1946e2771f870825ace14ee5787d6900ba8fa7d [^]

Verifies issue 34709 : Added automated test 'I34709_DeleteTicketWithPercentageDiscount'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicket.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketWithDeletedLines.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34709_DeleteTicketWithPercentageDiscount.java
---
(0092214)
hgbot (developer)
2016-12-08 15:02

 Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal
Changeset: 4e2a91eb8bfc5980da007045b6031969aacebd36
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Dec 08 14:59:52 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/4e2a91eb8bfc5980da007045b6031969aacebd36 [^]

Related to issue 34709. Fixed small problem in backport

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092224)
hgbot (developer)
2016-12-08 17:47

 Repository: retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal
Changeset: a6cd533dd0b6149d0bd27983e8da93b33d7b983c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Dec 08 17:47:26 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/a6cd533dd0b6149d0bd27983e8da93b33d7b983c [^]

Related to issue 34709. Fixed small problem in backport

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092277)
hgbot (developer)
2016-12-12 10:22

 Repository: tools/automation/pi-mobile
Changeset: f1946e2771f870825ace14ee5787d6900ba8fa7d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 08 14:29:16 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f1946e2771f870825ace14ee5787d6900ba8fa7d [^]

Verifies issue 34709 : Added automated test 'I34709_DeleteTicketWithPercentageDiscount'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicket.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketWithDeletedLines.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34709_DeleteTicketWithPercentageDiscount.java
---

- Issue History
Date Modified Username Field Change
2016-12-08 09:23 marvintm Type defect => backport
2016-12-08 09:23 marvintm Target Version => RR16Q3.4
2016-12-08 09:45 ranjith_qualiantech_com Assigned To asiermartirena => ranjith_qualiantech_com
2016-12-08 10:17 hgbot Checkin
2016-12-08 10:17 hgbot Note Added: 0092210
2016-12-08 10:17 hgbot Status scheduled => resolved
2016-12-08 10:17 hgbot Resolution open => fixed
2016-12-08 10:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97c95e2c63c9c9b72f43085bf624a58c6b32a41d [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.4/org.openbravo.retail.posterminal/rev/a467233e6f4d2eb238ab0286fb51e1c0c298caa7 [^]
2016-12-08 10:17 hgbot Checkin
2016-12-08 10:17 hgbot Note Added: 0092211
2016-12-08 10:17 hgbot Checkin
2016-12-08 10:17 hgbot Note Added: 0092212
2016-12-08 15:02 hgbot Checkin
2016-12-08 15:02 hgbot Note Added: 0092214
2016-12-08 17:47 hgbot Checkin
2016-12-08 17:47 hgbot Note Added: 0092224
2016-12-08 18:04 marvintm Review Assigned To => marvintm
2016-12-08 18:04 marvintm Status resolved => closed
2016-12-08 18:04 marvintm Fixed in Version => RR16Q3.4
2016-12-12 10:22 hgbot Checkin
2016-12-12 10:22 hgbot Note Added: 0092277

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker