0034709: Keeping track of deleted tickets is generating incorrect data

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034709

Retail Modules

Web POS

public

2016-09-13 11:44

2016-12-12 10:22

Reporter

marvintm

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q3.4

Fixed in Version

RR16Q3.4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0034709: Keeping track of deleted tickets is generating incorrect data

Description

Since 16Q2, it is possible to configure the Openbravo instance so that relevant deleted tickets are synchronized to the backend:

http://wiki.openbravo.com/wiki/Projects:Keep_Track_Of_Deleted_Ticket_Lines [^]

The idea is that these tickets would be changed so that their ordered quantity is set to zero. This works correctly, but there are several parts of the ticket which should be changed, and currently are not being set correctly. Specifically:

- Taxes (at both document and line level) should be zero, and currently are not.
- Totals at line level (both net and gross) should be zero, and currently are not.
- Discount information should also be discussed.

Steps To Reproduce

- Activate the functionality to keep track of deleted tickets, creating a preference for property "Web POS Save Removed Tickets"
- Create a ticket in the Web POS. Add some lines to it.
- Delete the ticket via the "Delete ticket" button.
- Check the ticket in the backend, and verify that tax information is not empty, and line totals are not zero.

Proposed Solution

Currently there is code in the OrderLoader that zeroes the totals of the header, and also the quantity of the lines. I believe a better approach would be to change the functionality so that the ticket in the client side is modified, by setting the quantity of each line to zero, and then recomputing the ticket using the existing calculateReceipt function in the client side.

In this way, the code would be much cleaner, the OrderLoader would not need to even know about the functionality, and would just save the modified ticket as it is.

Additional Information