Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033941
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-09-09 15:532017-06-27 12:40
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision80f6de5edaf2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033941: [SER-QA 1727] Error when selling a pack that contains a product with Item declaration

DescriptionPacks with item declaration show a different user.
Steps To Reproduce- To reproduce this issue it is required the Contact Info for Product project installed.
- Create a pack with products that have Item Declaration

- Login in Web POS
- Select a Customer
- Edit Customer to make sure it has Birth Date and Birth Place
- Sell Pack
- Item Declaration screen appears. Check that all fields are pre-filled
- Press Continue to avoid selling services if it has services
- Try to pay the ticket by clicking on total amount
- A pop-up appears saying that the Customer (Other customer, not the one selected in the ticket) does not have birth date or birth place.
Proposed SolutionSee patch attached.

It is just needed to add the packID to products that belongs to a pack.
TagsSER-QA
Attached Filesdiff file icon 1728.diff [^] (801 bytes) 2016-09-09 16:03 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0032972 closedjorge-garcia [Consistency] Promotions shouldn't split lines if not necessary. 

-  Notes
(0089925)
adrianromero (manager)
2016-09-13 16:19

 The proposed solution passes try succesfully -> https://ci.openbravo.com/view/try-retail/job/try-ret-init/5564/ [^]
(0090321)
hgbot (developer)
2016-09-28 07:12

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 80f6de5edaf29761d2bf852a736e32b9a5fe824d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 28 10:41:32 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/80f6de5edaf29761d2bf852a736e32b9a5fe824d [^]

Fixes issue 33941 : Added packId to product attributes while adding discount product to receipt

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0090455)
hgbot (developer)
2016-10-03 17:26

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 6c275711a2504abee44db5f31477133b06da3b87
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:25:30 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/6c275711a2504abee44db5f31477133b06da3b87 [^]

Related to issue 33941 : Added packId to product attributes while adding discount
product to receipt

Backed out changeset 80f6de5edaf2

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0090456)
jorge-garcia (reporter)
2016-10-03 17:28

 The solution created for this issue is risky and we cannot be sure it could cause problems in the future.

Backed out the changeset until a final decision is made by retail and but team.
(0091193)
jorge-garcia (reporter)
2016-11-07 10:54

 It's needed to test this issue in the Item Declaration module before give a proper solution.
(0093196)
dmitry_mezentsev (developer)
2017-01-04 17:39

 Guys,
Could you follow up with this issue, please?
It is for 2 months without a real action.
Thanks.
(0096490)
adrianromero (manager)
2017-05-09 15:54

 As explained in the issue report we checked that the changeset proposed passes try and also fixes the issue described when the "Item declaration" module is installed.

Also verified that this pack id is used in the "priceadjustment" property to find the required promotion, that is why it is needed to fill in here for this case:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/file/tip/web/org.openbravo.retail.discounts/js/promotion-pack.js#l159 [^]
(0097706)
marvintm (manager)
2017-06-27 12:40

 After further discussions, the problem has been fixed as part of the Item declaration project, and no changes are necessary in Core for the moment.

- Issue History
Date Modified Username Field Change
2016-09-09 15:53 adrianromero New Issue
2016-09-09 15:53 adrianromero Assigned To => Retail
2016-09-09 15:53 adrianromero Resolution time => 1473976800
2016-09-09 15:53 adrianromero Triggers an Emergency Pack => No
2016-09-09 16:00 adrianromero Summary Error when selling a pack that contains a product with Item declaration => [SER-QA 1728] Error when selling a pack that contains a product with Item declaration
2016-09-09 16:00 adrianromero Steps to Reproduce Updated View Revisions
2016-09-09 16:00 adrianromero Tag Attached: SER-QA
2016-09-09 16:03 adrianromero Proposed Solution updated
2016-09-09 16:03 adrianromero File Added: 1728.diff
2016-09-13 13:02 adrianromero Steps to Reproduce Updated View Revisions
2016-09-13 16:19 adrianromero Note Added: 0089925
2016-09-15 11:42 VictorVillar Resolution time 1473976800 => 1474581600
2016-09-21 17:03 VictorVillar Resolution time 1474581600 => 1475100000
2016-09-21 17:03 VictorVillar Summary [SER-QA 1728] Error when selling a pack that contains a product with Item declaration => [SER-QA 1727] Error when selling a pack that contains a product with Item declaration
2016-09-26 10:54 VictorVillar Resolution time 1475100000 => 1475445600
2016-09-27 07:45 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-09-27 07:45 ranjith_qualiantech_com Status new => scheduled
2016-09-27 07:59 ranjith_qualiantech_com Relationship added related to 0032972
2016-09-28 07:12 hgbot Checkin
2016-09-28 07:12 hgbot Note Added: 0090321
2016-09-28 07:12 hgbot Status scheduled => resolved
2016-09-28 07:12 hgbot Resolution open => fixed
2016-09-28 07:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/80f6de5edaf29761d2bf852a736e32b9a5fe824d [^]
2016-10-03 17:26 hgbot Checkin
2016-10-03 17:26 hgbot Note Added: 0090455
2016-10-03 17:28 jorge-garcia Note Added: 0090456
2016-10-03 17:28 jorge-garcia Status resolved => new
2016-10-03 17:28 jorge-garcia Resolution fixed => open
2016-10-05 07:18 ranjith_qualiantech_com Status new => acknowledged
2016-10-20 16:03 marvintm Resolution time 1475445600 => 1478127600
2016-11-03 11:39 marvintm Resolution time 1478127600 => 1478732400
2016-11-07 10:52 jorge-garcia Status acknowledged => scheduled
2016-11-07 10:54 jorge-garcia Note Added: 0091193
2016-11-07 10:54 jorge-garcia Assigned To ranjith_qualiantech_com => adrianromero
2016-11-07 10:54 jorge-garcia Status scheduled => feedback
2016-12-20 19:43 marvintm Resolution time 1478732400 =>
2017-01-04 17:39 dmitry_mezentsev Note Added: 0093196
2017-05-09 15:50 adrianromero Resolution time => 1495490400
2017-05-09 15:50 adrianromero Status feedback => new
2017-05-09 15:54 adrianromero Note Added: 0096490
2017-05-25 18:57 marvintm Resolution time 1495490400 => 1497477600
2017-06-16 10:10 marvintm Resolution time 1497477600 => 1498773600
2017-06-27 12:40 marvintm Review Assigned To => marvintm
2017-06-27 12:40 marvintm Note Added: 0097706
2017-06-27 12:40 marvintm Status new => closed
2017-06-27 12:40 marvintm Resolution open => no change required

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker