Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033941Retail ModulesWeb POSpublic2016-09-09 15:532017-06-27 12:40
Reporteradrianromero 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033941: [SER-QA 1727] Error when selling a pack that contains a product with Item declaration
DescriptionPacks with item declaration show a different user.
Steps To Reproduce- To reproduce this issue it is required the Contact Info for Product project installed.
- Create a pack with products that have Item Declaration

- Login in Web POS
- Select a Customer
- Edit Customer to make sure it has Birth Date and Birth Place
- Sell Pack
- Item Declaration screen appears. Check that all fields are pre-filled
- Press Continue to avoid selling services if it has services
- Try to pay the ticket by clicking on total amount
- A pop-up appears saying that the Customer (Other customer, not the one selected in the ticket) does not have birth date or birth place.
Proposed SolutionSee patch attached.

It is just needed to add the packID to products that belongs to a pack.
Additional Information
TagsSER-QA
Relationships
related to design defect 0032972 closed jorge-garcia [Consistency] Promotions shouldn't split lines if not necessary. 
Attached Filesdiff 1728.diff (801) 2016-09-09 16:03
https://issues.openbravo.com/file_download.php?file_id=9799&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-09 15:53adrianromeroNew Issue
2016-09-09 15:53adrianromeroAssigned To => Retail
2016-09-09 15:53adrianromeroResolution time => 1473976800
2016-09-09 15:53adrianromeroTriggers an Emergency Pack => No
2016-09-09 16:00adrianromeroSummaryError when selling a pack that contains a product with Item declaration => [SER-QA 1728] Error when selling a pack that contains a product with Item declaration
2016-09-09 16:00adrianromeroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13089#r13089
2016-09-09 16:00adrianromeroTag Attached: SER-QA
2016-09-09 16:03adrianromeroProposed Solution updated
2016-09-09 16:03adrianromeroFile Added: 1728.diff
2016-09-13 13:02adrianromeroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13100#r13100
2016-09-13 16:19adrianromeroNote Added: 0089925
2016-09-15 11:42VictorVillarResolution time1473976800 => 1474581600
2016-09-21 17:03VictorVillarResolution time1474581600 => 1475100000
2016-09-21 17:03VictorVillarSummary[SER-QA 1728] Error when selling a pack that contains a product with Item declaration => [SER-QA 1727] Error when selling a pack that contains a product with Item declaration
2016-09-26 10:54VictorVillarResolution time1475100000 => 1475445600
2016-09-27 07:45ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-09-27 07:45ranjith_qualiantech_comStatusnew => scheduled
2016-09-27 07:59ranjith_qualiantech_comRelationship addedrelated to 0032972
2016-09-28 07:12hgbotCheckin
2016-09-28 07:12hgbotNote Added: 0090321
2016-09-28 07:12hgbotStatusscheduled => resolved
2016-09-28 07:12hgbotResolutionopen => fixed
2016-09-28 07:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/80f6de5edaf29761d2bf852a736e32b9a5fe824d [^]
2016-10-03 17:26hgbotCheckin
2016-10-03 17:26hgbotNote Added: 0090455
2016-10-03 17:28jorge-garciaNote Added: 0090456
2016-10-03 17:28jorge-garciaStatusresolved => new
2016-10-03 17:28jorge-garciaResolutionfixed => open
2016-10-05 07:18ranjith_qualiantech_comStatusnew => acknowledged
2016-10-20 16:03marvintmResolution time1475445600 => 1478127600
2016-11-03 11:39marvintmResolution time1478127600 => 1478732400
2016-11-07 10:52jorge-garciaStatusacknowledged => scheduled
2016-11-07 10:54jorge-garciaNote Added: 0091193
2016-11-07 10:54jorge-garciaAssigned Toranjith_qualiantech_com => adrianromero
2016-11-07 10:54jorge-garciaStatusscheduled => feedback
2016-12-20 19:43marvintmResolution time1478732400 =>
2017-01-04 17:39dmitry_mezentsevNote Added: 0093196
2017-05-09 15:50adrianromeroResolution time => 1495490400
2017-05-09 15:50adrianromeroStatusfeedback => new
2017-05-09 15:54adrianromeroNote Added: 0096490
2017-05-25 18:57marvintmResolution time1495490400 => 1497477600
2017-06-16 10:10marvintmResolution time1497477600 => 1498773600
2017-06-27 12:40marvintmReview Assigned To => marvintm
2017-06-27 12:40marvintmNote Added: 0097706
2017-06-27 12:40marvintmStatusnew => closed
2017-06-27 12:40marvintmResolutionopen => no change required

Notes
(0089925)
adrianromero   
2016-09-13 16:19   
The proposed solution passes try succesfully -> https://ci.openbravo.com/view/try-retail/job/try-ret-init/5564/ [^]
(0090321)
hgbot   
2016-09-28 07:12   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 80f6de5edaf29761d2bf852a736e32b9a5fe824d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 28 10:41:32 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/80f6de5edaf29761d2bf852a736e32b9a5fe824d [^]

Fixes issue 33941 : Added packId to product attributes while adding discount product to receipt

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0090455)
hgbot   
2016-10-03 17:26   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 6c275711a2504abee44db5f31477133b06da3b87
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:25:30 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/6c275711a2504abee44db5f31477133b06da3b87 [^]

Related to issue 33941 : Added packId to product attributes while adding discount
product to receipt

Backed out changeset 80f6de5edaf2

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0090456)
jorge-garcia   
2016-10-03 17:28   
The solution created for this issue is risky and we cannot be sure it could cause problems in the future.

Backed out the changeset until a final decision is made by retail and but team.
(0091193)
jorge-garcia   
2016-11-07 10:54   
It's needed to test this issue in the Item Declaration module before give a proper solution.
(0093196)
dmitry_mezentsev   
2017-01-04 17:39   
Guys,
Could you follow up with this issue, please?
It is for 2 months without a real action.
Thanks.
(0096490)
adrianromero   
2017-05-09 15:54   
As explained in the issue report we checked that the changeset proposed passes try and also fixes the issue described when the "Item declaration" module is installed.

Also verified that this pack id is used in the "priceadjustment" property to find the required promotion, that is why it is needed to fill in here for this case:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/file/tip/web/org.openbravo.retail.discounts/js/promotion-pack.js#l159 [^]
(0097706)
marvintm   
2017-06-27 12:40   
After further discussions, the problem has been fixed as part of the Item declaration project, and no changes are necessary in Core for the moment.