0033815: Initialization in OBCriteria should not be prevented under some circumstances

Description

Initialization in OBCriteria should not be prevented under some circumstances, for example if we use list() with a new order by clause to an existing criteria after calling count(), i.e.:

  if (plVersionCrit.count() > 0) {
    plVersionCrit.addOrderBy(PriceListVersion.PROPERTY_VALIDFROMDATE, false);
    return plVersionCrit.list().get(0);
   }

The call to list does not initialize the query so it will skip the order by clause.

Steps To Reproduce

The PricelistVersionFilterExpression stops working as expected:

1 - Log in livebuilds 16Q3
2 - Go to Price List window and open "Tarifa de ventas"
3 - Create a new "Price list version", and use as base version "Tarifa de ventas"
4 - Go to "Product Price" tab
5 - Change the unit price of "Agua sin Gas 1L"
6 - Go to "Sales Order" and create a new sales order, select the price list "Tarifa de ventas"
7 - Create a new line
8 - Realize that when select the "Agua sin Gas 1L" product, the prices are the older prices.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0033814

3.0PR16Q4

closed

caristu

Initialization in OBCriteria should not be prevented under some circumstances

Notes
(0089411) hgbot (developer) 2016-08-25 16:16	Repository: erp/backports/3.0PR16Q3.1 Changeset: 35b4c1c83bab7951af8638b787dfadfe9729fd87 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Thu Aug 25 16:15:48 2016 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR16Q3.1/rev/35b4c1c83bab7951af8638b787dfadfe9729fd87 [^] fixes issue 33815: backed out initialization prevention changes --- M src/org/openbravo/dal/service/OBCriteria.java ---

(0089413) shuehner (administrator) 2016-08-25 17:15	Verified that the backport was done correctly. Q2 version of the OBCriteria file is identical to tip of Q3.1 branch after the backout (ignoring a formal change). Also verified functionally that the added 'orderby' is no longer missing in the specified testcase (undoing changes in 33809,33811 for this test to trigger the regression).

Issue History
Date Modified	Username	Field	Change
2016-08-25 15:44	caristu	Type	defect => backport
2016-08-25 15:44	caristu	Target Version	=> 3.0PR16Q3.1
2016-08-25 16:16	hgbot	Checkin
2016-08-25 16:16	hgbot	Note Added: 0089411
2016-08-25 16:16	hgbot	Status	scheduled => resolved
2016-08-25 16:16	hgbot	Resolution	open => fixed
2016-08-25 16:16	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR16Q3.1/rev/35b4c1c83bab7951af8638b787dfadfe9729fd87 [^]
2016-08-25 16:17	caristu	Review Assigned To	=> shuehner
2016-08-25 16:17	caristu	Issue Monitored: shuehner
2016-08-25 17:15	shuehner	Note Added: 0089413
2016-08-25 17:15	shuehner	Status	resolved => closed
2016-08-25 17:15	shuehner	Fixed in Version	=> 3.0PR16Q3.1