0033815: Initialization in OBCriteria should not be prevented under some circumstances

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033815

Openbravo ERP

A. Platform

public

2016-08-25 15:44

2016-08-25 17:15

Reporter

caristu

Assigned To

platform

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR16Q3.1

Fixed in Version

3.0PR16Q3.1

Merge Request Status

Review Assigned To

shuehner

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - QA Approved

Regression date

2016-06-10

Regression introduced in release

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/ec3e4492a91c88e84d09e34b9e3e487f13ad3cb8 [^]

Triggers an Emergency Pack

Summary

0033815: Initialization in OBCriteria should not be prevented under some circumstances

Description

Initialization in OBCriteria should not be prevented under some circumstances, for example if we use list() with a new order by clause to an existing criteria after calling count(), i.e.:

  if (plVersionCrit.count() > 0) {
    plVersionCrit.addOrderBy(PriceListVersion.PROPERTY_VALIDFROMDATE, false);
    return plVersionCrit.list().get(0);
   }

The call to list does not initialize the query so it will skip the order by clause.

Steps To Reproduce

The PricelistVersionFilterExpression stops working as expected:

1 - Log in livebuilds 16Q3
2 - Go to Price List window and open "Tarifa de ventas"
3 - Create a new "Price list version", and use as base version "Tarifa de ventas"
4 - Go to "Product Price" tab
5 - Change the unit price of "Agua sin Gas 1L"
6 - Go to "Sales Order" and create a new sales order, select the price list "Tarifa de ventas"
7 - Create a new line
8 - Realize that when select the "Agua sin Gas 1L" product, the prices are the older prices.

Proposed Solution

Additional Information