0033791: PricelistVersionFilterExpression & PriceListVersionFilterExpressionName are 99% identical

Description

Those 2 files are (ignoring formal changes) completely identical except of a single line:

@@ -42,7 +61,7 @@
     Date date = getDate();
     PriceListVersion priceListVersion = getPriceListVersion(priceList, date);
     if (priceListVersion != null) {
- return priceListVersion.getId();
+ return priceListVersion.getName();
     }
     return "";
   }

That should be refactored as i.e. 33705 & 33790 had to find & fix same bug in both.

Note: Both live in same javapackage so it should be possible to do some code-sharing probably easily without api change.

Steps To Reproduce

cd src/org/openbravo/erpCommon/info
diff -u PriceListVersionFilterExpression.java PriceListVersionFilterExpressionName.java

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0033705		closed	shuehner	Double query in PricelistVersionFilterExpression (product selector)
related to	defect	0033790		closed	shuehner	Accidental double query in PriceListVersionFilterExpressionName (order lines, product selector dropdown)

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2016-08-24 11:47	shuehner	New Issue
2016-08-24 11:47	shuehner	Assigned To	=> platform
2016-08-24 11:47	shuehner	OBNetwork customer	=> No
2016-08-24 11:47	shuehner	Modules	=> Core
2016-08-24 11:47	shuehner	Triggers an Emergency Pack	=> No
2016-08-24 11:47	shuehner	Relationship added	related to 0033705
2016-08-24 11:47	shuehner	Relationship added	related to 0033790
2016-08-24 15:58	NaroaIriarte	Assigned To	platform => NaroaIriarte
2016-08-24 15:58	NaroaIriarte	Status	new => acknowledged
2016-08-25 15:19	caristu	Assigned To	NaroaIriarte => Triage Finance