0033791: PricelistVersionFilterExpression & PriceListVersionFilterExpressionName are 99% identical

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033791

Openbravo ERP

A. Platform

public

2016-08-24 11:47

2016-08-25 15:19

Reporter

shuehner

Assigned To

Triage Finance

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033791: PricelistVersionFilterExpression & PriceListVersionFilterExpressionName are 99% identical

Description

Those 2 files are (ignoring formal changes) completely identical except of a single line:

@@ -42,7 +61,7 @@
     Date date = getDate();
     PriceListVersion priceListVersion = getPriceListVersion(priceList, date);
     if (priceListVersion != null) {
- return priceListVersion.getId();
+ return priceListVersion.getName();
     }
     return "";
   }

That should be refactored as i.e. 33705 & 33790 had to find & fix same bug in both.

Note: Both live in same javapackage so it should be possible to do some code-sharing probably easily without api change.

Steps To Reproduce

cd src/org/openbravo/erpCommon/info
diff -u PriceListVersionFilterExpression.java PriceListVersionFilterExpressionName.java

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0033705		closed	shuehner	Double query in PricelistVersionFilterExpression (product selector)
related to	defect	0033790		closed	shuehner	Accidental double query in PriceListVersionFilterExpressionName (order lines, product selector dropdown)