Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033775
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] B. User interfacemajorsometimes2016-08-23 22:542016-09-02 14:28
ReporterrbianchiniView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision321a74b76ac7
ProjectionnoneETAnoneTarget Version3.0PR16Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR16Q2.1SCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket43365
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033775: Create New - Does not Work when corresponding window has a default saved view

DescriptionCreate New - Does not Work when corresponding has a default saved view

tested in 16Q2.1, 16Q1.3, 15Q4, 15Q3, 15Q2
Steps To Reproduce1. Create a saved view in the Product window and make it your default (filter to a single product)
2. Click on Create New menu option and select Product
3. Product tab opens up and goes blank - cannot enter a new product [NOK] (see attached screenshot)

If you change the default view back to the Standard View, then Create New again works.
TagsNo tags attached.
Attached Filespng file icon Selección_009.png [^] (37,436 bytes) 2016-08-23 22:54

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 00338953.0PR16Q4 closedcaristu Open direct stops working after using create new under some circumstances 

-  Notes
(0089467)
caristu (viewer)
2016-08-26 15:35
edited on: 2016-08-26 15:35

 The following error is displayed in the console:

Class.js:1796 Uncaught NotFoundError: Failed to set the 'innerHTML' property on 'Element': The node to be removed is no longer a child of this node. Perhaps it was moved in a 'blur' event handler?
(0089487)
hgbot (developer)
2016-08-29 11:31

 Repository: erp/devel/pi
Changeset: 9156a78d8ad619d8071241b3089d2b6c787e3979
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Aug 29 11:24:40 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^]

fixes issue 33775: Create New is not working with saved views marked as default

When using Create New menu entry to create a new record in a window that has a saved view marked as default, the form was being opened before the loading of the saved view, causing the problem.

To fix it, now the opening of the form is deferred until the window is loaded (including the load of the saved views, if any).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-recent-utilities.js
---
(0089488)
caristu (viewer)
2016-08-29 11:35

 Added test into TestLink to take into account this case: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10150 [^]
(0089519)
hudsonbot (viewer)
2016-08-29 21:02

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bc86301d6ff4 [^]
Maturity status: Test
(0089547)
alostale (viewer)
2016-08-30 12:25

 The patch fixes creating new from quick launch menu, but the issue is still reproducible when the new record is created from recent views menu.

https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0089581)
hgbot (developer)
2016-08-31 10:28

 Repository: erp/devel/pi
Changeset: 55c319563446a1bf452d936fe028693d012ad1bb
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 31 10:27:37 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/55c319563446a1bf452d936fe028693d012ad1bb [^]

related to issue 33775: backed out changes

Backed out changes as the problem is still reproducible

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-recent-utilities.js
---
(0089621)
hudsonbot (viewer)
2016-08-31 15:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5d428c349064 [^]
Maturity status: Test
(0089657)
hgbot (developer)
2016-09-01 13:11

 Repository: erp/devel/pi
Changeset: 321a74b76ac76e39a6f0e9ec6003c13467360fb9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 01 13:06:11 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/321a74b76ac76e39a6f0e9ec6003c13467360fb9 [^]

fixes issue 33775: Create New is not working with saved views marked as default

When using Create New menu entry, the opening of the form is deferred until the window is loaded (including the load of the saved views, if any).

Together with this, now the grid data is not loaded when using Create New. This has two main advantages:
  - Better performance: the data will not be loaded when opening the window. If desired, the user can load it after saving/canceling the edition.
  - Homogeneus behavior: this feature will now work as the direct record opening, where the grid is filtered to show just the record being opened.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
---
(0089692)
hgbot (developer)
2016-09-02 09:04

 Repository: erp/devel/pi
Changeset: bb58b51ad6f7a374f6d3481ee77df9306372cc60
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Sep 02 09:03:51 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bb58b51ad6f7a374f6d3481ee77df9306372cc60 [^]

related to issue 33775: take into account case when license is not professional

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0089699)
alostale (viewer)
2016-09-02 13:20

 code reviewed

Tested the combinations of
 * saved default view/standard default view
 * create new from top menu/create new from recent views menu
(0089705)
hudsonbot (viewer)
2016-09-02 14:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test
(0089711)
hudsonbot (viewer)
2016-09-02 14:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-08-23 22:54 rbianchini New Issue
2016-08-23 22:54 rbianchini Assigned To => platform
2016-08-23 22:54 rbianchini File Added: Selección_009.png
2016-08-23 22:54 rbianchini OBNetwork customer => Yes
2016-08-23 22:54 rbianchini Web browser => Google Chrome
2016-08-23 22:54 rbianchini Modules => Core
2016-08-23 22:54 rbianchini Support ticket => 43365
2016-08-23 22:54 rbianchini Triggers an Emergency Pack => No
2016-08-24 13:56 caristu Status new => acknowledged
2016-08-26 14:42 caristu Web browser Google Chrome => Google Chrome
2016-08-26 14:42 caristu Severity minor => major
2016-08-26 14:42 caristu Target Version => 3.0PR16Q4
2016-08-26 14:42 caristu Status acknowledged => scheduled
2016-08-26 14:42 caristu Assigned To platform => caristu
2016-08-26 14:42 caristu Review Assigned To => alostale
2016-08-26 14:42 caristu Web browser Google Chrome => Google Chrome
2016-08-26 14:42 caristu Issue Monitored: alostale
2016-08-26 15:35 caristu Note Added: 0089467
2016-08-26 15:35 caristu Note Edited: 0089467 View Revisions
2016-08-29 11:31 hgbot Checkin
2016-08-29 11:31 hgbot Note Added: 0089487
2016-08-29 11:31 hgbot Status scheduled => resolved
2016-08-29 11:31 hgbot Resolution open => fixed
2016-08-29 11:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^]
2016-08-29 11:35 caristu Note Added: 0089488
2016-08-29 21:02 hudsonbot Checkin
2016-08-29 21:02 hudsonbot Note Added: 0089519
2016-08-30 12:07 alostale Web browser Google Chrome => Google Chrome
2016-08-30 12:07 alostale Summary Create New - Does not Work when corresponding has a default saved view => Create New - Does not Work when corresponding window has a default saved view
2016-08-30 12:25 alostale Note Added: 0089547
2016-08-30 12:25 alostale Status resolved => new
2016-08-30 12:25 alostale Resolution fixed => open
2016-08-31 10:28 hgbot Checkin
2016-08-31 10:28 hgbot Note Added: 0089581
2016-08-31 14:56 caristu Status new => scheduled
2016-08-31 15:12 hudsonbot Checkin
2016-08-31 15:12 hudsonbot Note Added: 0089621
2016-09-01 13:11 hgbot Checkin
2016-09-01 13:11 hgbot Note Added: 0089657
2016-09-01 13:11 hgbot Status scheduled => resolved
2016-09-01 13:11 hgbot Resolution open => fixed
2016-09-01 13:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^] => http://code.openbravo.com/erp/devel/pi/rev/321a74b76ac76e39a6f0e9ec6003c13467360fb9 [^]
2016-09-02 09:04 hgbot Checkin
2016-09-02 09:04 hgbot Note Added: 0089692
2016-09-02 13:20 alostale Note Added: 0089699
2016-09-02 13:20 alostale Status resolved => closed
2016-09-02 13:20 alostale Fixed in Version => 3.0PR16Q4
2016-09-02 14:28 hudsonbot Checkin
2016-09-02 14:28 hudsonbot Note Added: 0089705
2016-09-02 14:28 hudsonbot Checkin
2016-09-02 14:28 hudsonbot Note Added: 0089711
2016-09-05 13:51 caristu Relationship added causes 0033895

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker