Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033775Openbravo ERPB. User interfacepublic2016-08-23 22:542016-09-02 14:28
Reporterrbianchini 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q2.1 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033775: Create New - Does not Work when corresponding window has a default saved view
DescriptionCreate New - Does not Work when corresponding has a default saved view

tested in 16Q2.1, 16Q1.3, 15Q4, 15Q3, 15Q2
Steps To Reproduce1. Create a saved view in the Product window and make it your default (filter to a single product)
2. Click on Create New menu option and select Product
3. Product tab opens up and goes blank - cannot enter a new product [NOK] (see attached screenshot)

If you change the default view back to the Standard View, then Create New again works.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 00338953.0PR16Q4 closed caristu Open direct stops working after using create new under some circumstances 
Attached Filespng Selección_009.png (37,436) 2016-08-23 22:54
https://issues.openbravo.com/file_download.php?file_id=9747&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-08-23 22:54rbianchiniNew Issue
2016-08-23 22:54rbianchiniAssigned To => platform
2016-08-23 22:54rbianchiniFile Added: Selección_009.png
2016-08-23 22:54rbianchiniWeb browser => Google Chrome
2016-08-23 22:54rbianchiniModules => Core
2016-08-23 22:54rbianchiniTriggers an Emergency Pack => No
2016-08-24 13:56caristuStatusnew => acknowledged
2016-08-26 14:42caristuWeb browserGoogle Chrome => Google Chrome
2016-08-26 14:42caristuSeverityminor => major
2016-08-26 14:42caristuTarget Version => 3.0PR16Q4
2016-08-26 14:42caristuStatusacknowledged => scheduled
2016-08-26 14:42caristuAssigned Toplatform => caristu
2016-08-26 14:42caristuReview Assigned To => alostale
2016-08-26 14:42caristuWeb browserGoogle Chrome => Google Chrome
2016-08-26 14:42caristuIssue Monitored: alostale
2016-08-26 15:35caristuNote Added: 0089467
2016-08-26 15:35caristuNote Edited: 0089467bug_revision_view_page.php?bugnote_id=0089467#r12923
2016-08-29 11:31hgbotCheckin
2016-08-29 11:31hgbotNote Added: 0089487
2016-08-29 11:31hgbotStatusscheduled => resolved
2016-08-29 11:31hgbotResolutionopen => fixed
2016-08-29 11:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^]
2016-08-29 11:35caristuNote Added: 0089488
2016-08-29 21:02hudsonbotCheckin
2016-08-29 21:02hudsonbotNote Added: 0089519
2016-08-30 12:07alostaleWeb browserGoogle Chrome => Google Chrome
2016-08-30 12:07alostaleSummaryCreate New - Does not Work when corresponding has a default saved view => Create New - Does not Work when corresponding window has a default saved view
2016-08-30 12:25alostaleNote Added: 0089547
2016-08-30 12:25alostaleStatusresolved => new
2016-08-30 12:25alostaleResolutionfixed => open
2016-08-31 10:28hgbotCheckin
2016-08-31 10:28hgbotNote Added: 0089581
2016-08-31 14:56caristuStatusnew => scheduled
2016-08-31 15:12hudsonbotCheckin
2016-08-31 15:12hudsonbotNote Added: 0089621
2016-09-01 13:11hgbotCheckin
2016-09-01 13:11hgbotNote Added: 0089657
2016-09-01 13:11hgbotStatusscheduled => resolved
2016-09-01 13:11hgbotResolutionopen => fixed
2016-09-01 13:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^] => http://code.openbravo.com/erp/devel/pi/rev/321a74b76ac76e39a6f0e9ec6003c13467360fb9 [^]
2016-09-02 09:04hgbotCheckin
2016-09-02 09:04hgbotNote Added: 0089692
2016-09-02 13:20alostaleNote Added: 0089699
2016-09-02 13:20alostaleStatusresolved => closed
2016-09-02 13:20alostaleFixed in Version => 3.0PR16Q4
2016-09-02 14:28hudsonbotCheckin
2016-09-02 14:28hudsonbotNote Added: 0089705
2016-09-02 14:28hudsonbotCheckin
2016-09-02 14:28hudsonbotNote Added: 0089711
2016-09-05 13:51caristuRelationship addedcauses 0033895

Notes
(0089467)
caristu   
2016-08-26 15:35   
The following error is displayed in the console:

Class.js:1796 Uncaught NotFoundError: Failed to set the 'innerHTML' property on 'Element': The node to be removed is no longer a child of this node. Perhaps it was moved in a 'blur' event handler?
(0089487)
hgbot   
2016-08-29 11:31   
Repository: erp/devel/pi
Changeset: 9156a78d8ad619d8071241b3089d2b6c787e3979
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Aug 29 11:24:40 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9156a78d8ad619d8071241b3089d2b6c787e3979 [^]

fixes issue 33775: Create New is not working with saved views marked as default

When using Create New menu entry to create a new record in a window that has a saved view marked as default, the form was being opened before the loading of the saved view, causing the problem.

To fix it, now the opening of the form is deferred until the window is loaded (including the load of the saved views, if any).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-recent-utilities.js
---
(0089488)
caristu   
2016-08-29 11:35   
Added test into TestLink to take into account this case: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10150 [^]
(0089519)
hudsonbot   
2016-08-29 21:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bc86301d6ff4 [^]
Maturity status: Test
(0089547)
alostale   
2016-08-30 12:25   
The patch fixes creating new from quick launch menu, but the issue is still reproducible when the new record is created from recent views menu.

https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0089581)
hgbot   
2016-08-31 10:28   
Repository: erp/devel/pi
Changeset: 55c319563446a1bf452d936fe028693d012ad1bb
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Aug 31 10:27:37 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/55c319563446a1bf452d936fe028693d012ad1bb [^]

related to issue 33775: backed out changes

Backed out changes as the problem is still reproducible

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-recent-utilities.js
---
(0089621)
hudsonbot   
2016-08-31 15:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5d428c349064 [^]
Maturity status: Test
(0089657)
hgbot   
2016-09-01 13:11   
Repository: erp/devel/pi
Changeset: 321a74b76ac76e39a6f0e9ec6003c13467360fb9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Sep 01 13:06:11 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/321a74b76ac76e39a6f0e9ec6003c13467360fb9 [^]

fixes issue 33775: Create New is not working with saved views marked as default

When using Create New menu entry, the opening of the form is deferred until the window is loaded (including the load of the saved views, if any).

Together with this, now the grid data is not loaded when using Create New. This has two main advantages:
  - Better performance: the data will not be loaded when opening the window. If desired, the user can load it after saving/canceling the edition.
  - Homogeneus behavior: this feature will now work as the direct record opening, where the grid is filtered to show just the record being opened.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
---
(0089692)
hgbot   
2016-09-02 09:04   
Repository: erp/devel/pi
Changeset: bb58b51ad6f7a374f6d3481ee77df9306372cc60
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Sep 02 09:03:51 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bb58b51ad6f7a374f6d3481ee77df9306372cc60 [^]

related to issue 33775: take into account case when license is not professional

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0089699)
alostale   
2016-09-02 13:20   
code reviewed

Tested the combinations of
 * saved default view/standard default view
 * create new from top menu/create new from recent views menu
(0089705)
hudsonbot   
2016-09-02 14:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test
(0089711)
hudsonbot   
2016-09-02 14:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test