Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033772
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2016-08-23 17:192016-08-25 10:40
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revisionb7fdb632c2b6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033772: Accidental double query in SelectorDefaultFilterActionHandler

DescriptionSimilar to issue 33704. Do not call count() + later list() to avoid 2 sql queries for same data
Steps To ReproduceWith debugging code from https://issues.openbravo.com/view.php?id=33767 [^]

Open Sales Invoice window
New in form view
Press 'magnifying glass' symbol to open new selector 'overlay'

See double query
TagsPerformance
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0033704 closedshuehner Accidental double query in 'selector dropdown' of new style selectors 
related to feature request 0033767 closedplatform Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object 

-  Notes
(0089323)
hgbot (developer)
2016-08-23 22:04

Repository: erp/devel/pi
Changeset: b7fdb632c2b64a6f5049f3fa700d0b6097e5a235
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 23 17:20:57 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b7fdb632c2b64a6f5049f3fa700d0b6097e5a235 [^]

Fixed 33772. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
---
(0089381)
caristu (developer)
2016-08-25 10:40

Code reviewed

- Issue History
Date Modified Username Field Change
2016-08-23 17:19 shuehner New Issue
2016-08-23 17:19 shuehner Assigned To => platform
2016-08-23 17:19 shuehner Modules => Core
2016-08-23 17:19 shuehner Triggers an Emergency Pack => No
2016-08-23 17:20 shuehner Relationship added related to 0033704
2016-08-23 17:20 shuehner Relationship added related to 0033767
2016-08-23 17:21 shuehner Tag Attached: Performance
2016-08-23 22:04 hgbot Checkin
2016-08-23 22:04 hgbot Note Added: 0089323
2016-08-23 22:04 hgbot Status new => resolved
2016-08-23 22:04 hgbot Resolution open => fixed
2016-08-23 22:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b7fdb632c2b64a6f5049f3fa700d0b6097e5a235 [^]
2016-08-23 22:04 shuehner Assigned To platform => shuehner
2016-08-23 22:05 shuehner Review Assigned To => caristu
2016-08-25 10:40 caristu Note Added: 0089381
2016-08-25 10:40 caristu Status resolved => closed
2016-08-25 10:40 caristu Fixed in Version => 3.0PR16Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker