Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033772Openbravo ERPA. Platformpublic2016-08-23 17:192016-08-25 10:40
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033772: Accidental double query in SelectorDefaultFilterActionHandler
DescriptionSimilar to issue 33704. Do not call count() + later list() to avoid 2 sql queries for same data
Steps To ReproduceWith debugging code from https://issues.openbravo.com/view.php?id=33767 [^]

Open Sales Invoice window
New in form view
Press 'magnifying glass' symbol to open new selector 'overlay'

See double query
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0033704 closed shuehner Accidental double query in 'selector dropdown' of new style selectors 
related to feature request 0033767 closed platform Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-23 17:19shuehnerNew Issue
2016-08-23 17:19shuehnerAssigned To => platform
2016-08-23 17:19shuehnerModules => Core
2016-08-23 17:19shuehnerTriggers an Emergency Pack => No
2016-08-23 17:20shuehnerRelationship addedrelated to 0033704
2016-08-23 17:20shuehnerRelationship addedrelated to 0033767
2016-08-23 17:21shuehnerTag Attached: Performance
2016-08-23 22:04hgbotCheckin
2016-08-23 22:04hgbotNote Added: 0089323
2016-08-23 22:04hgbotStatusnew => resolved
2016-08-23 22:04hgbotResolutionopen => fixed
2016-08-23 22:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b7fdb632c2b64a6f5049f3fa700d0b6097e5a235 [^]
2016-08-23 22:04shuehnerAssigned Toplatform => shuehner
2016-08-23 22:05shuehnerReview Assigned To => caristu
2016-08-25 10:40caristuNote Added: 0089381
2016-08-25 10:40caristuStatusresolved => closed
2016-08-25 10:40caristuFixed in Version => 3.0PR16Q4

Notes
(0089323)
hgbot   
2016-08-23 22:04   
Repository: erp/devel/pi
Changeset: b7fdb632c2b64a6f5049f3fa700d0b6097e5a235
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 23 17:20:57 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b7fdb632c2b64a6f5049f3fa700d0b6097e5a235 [^]

Fixed 33772. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
---
(0089381)
caristu   
2016-08-25 10:40   
Code reviewed