Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033126 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2016-06-02 21:05 | 2017-11-30 10:09 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | af7f765c5acb | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033126: Avoid select to ad_role during creation of c_import_entry | |||||||
| Description | The code to create a new import entry does read from ad_role via OBDal.getInstance().get just to pass the reference on to a BOB. That causes a sql select to ad_role via ad_role_id which can be avoided by using DAL proxy. | |||||||
| Steps To Reproduce | Check ImportEntryManager.createImportEntry function, the setRole call. | |||||||
| Proposed Solution | Replace reading Role by proxy usage | |||||||
| Tags | Performance | |||||||
| Attached Files |  33126.diff [^] (710 bytes) 2016-06-02 21:06 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0087120) hgbot (developer) 2016-06-09 15:35 |
Repository: erp/devel/pi Changeset: af7f765c5acb0866be95c20196a7a999710ec2d2 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Jun 07 16:57:54 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/af7f765c5acb0866be95c20196a7a999710ec2d2 [^] Fixed 33126. Creating c_import_entry use Proxy to avoid reading from ad_role Read to ad_role can be avoided by using Proxy object instead. --- M src/org/openbravo/service/importprocess/ImportEntryManager.java --- |
|
(0087121) hgbot (developer) 2016-06-09 15:35 |
Repository: erp/devel/pi Changeset: 5ea6451d509257da55091173c733ffb5f2f56076 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Jun 09 15:27:20 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5ea6451d509257da55091173c733ffb5f2f56076 [^] Issue 33126. Improve change by used getProxy variant returning proper Role.class instance directly instead of a bob and needing to cast it. --- M src/org/openbravo/service/importprocess/ImportEntryManager.java --- |
|
(0087599) hudsonbot (viewer) 2016-06-17 19:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-02 21:05 | shuehner | New Issue | |
| 2016-06-02 21:05 | shuehner | Assigned To | => platform |
| 2016-06-02 21:05 | shuehner | OBNetwork customer | => No |
| 2016-06-02 21:05 | shuehner | Modules | => Core |
| 2016-06-02 21:05 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-02 21:06 | shuehner | File Added: 33126.diff | |
| 2016-06-02 21:06 | shuehner | Tag Attached: Performance | |
| 2016-06-03 15:05 | caristu | Relationship added | related to 0033129 |
| 2016-06-09 15:21 | shuehner | Assigned To | platform => shuehner |
| 2016-06-09 15:21 | shuehner | Review Assigned To | => marvintm |
| 2016-06-09 15:35 | hgbot | Checkin | |
| 2016-06-09 15:35 | hgbot | Note Added: 0087120 | |
| 2016-06-09 15:35 | hgbot | Status | new => resolved |
| 2016-06-09 15:35 | hgbot | Resolution | open => fixed |
| 2016-06-09 15:35 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/af7f765c5acb0866be95c20196a7a999710ec2d2 [^] |
| 2016-06-09 15:35 | hgbot | Checkin | |
| 2016-06-09 15:35 | hgbot | Note Added: 0087121 | |
| 2016-06-10 09:05 | marvintm | Status | resolved => closed |
| 2016-06-17 19:38 | hudsonbot | Checkin | |
| 2016-06-17 19:38 | hudsonbot | Note Added: 0087599 | |
| 2017-11-30 10:09 | shuehner | Fixed in Version | => 3.0PR16Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |