Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033126Openbravo ERPA. Platformpublic2016-06-02 21:052017-11-30 10:09
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033126: Avoid select to ad_role during creation of c_import_entry
DescriptionThe code to create a new import entry does read from ad_role via OBDal.getInstance().get just to pass the reference on to a BOB.

That causes a sql select to ad_role via ad_role_id which can be avoided by using DAL proxy.
Steps To ReproduceCheck ImportEntryManager.createImportEntry function, the setRole call.
Proposed SolutionReplace reading Role by proxy usage
Additional Information
TagsPerformance
Relationships
related to defect 0033129 closed alostale unneeded object initialization for DAL insertion 
Attached Filesdiff 33126.diff (710) 2016-06-02 21:06
https://issues.openbravo.com/file_download.php?file_id=9478&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-06-02 21:05shuehnerNew Issue
2016-06-02 21:05shuehnerAssigned To => platform
2016-06-02 21:05shuehnerModules => Core
2016-06-02 21:05shuehnerTriggers an Emergency Pack => No
2016-06-02 21:06shuehnerFile Added: 33126.diff
2016-06-02 21:06shuehnerTag Attached: Performance
2016-06-03 15:05caristuRelationship addedrelated to 0033129
2016-06-09 15:21shuehnerAssigned Toplatform => shuehner
2016-06-09 15:21shuehnerReview Assigned To => marvintm
2016-06-09 15:35hgbotCheckin
2016-06-09 15:35hgbotNote Added: 0087120
2016-06-09 15:35hgbotStatusnew => resolved
2016-06-09 15:35hgbotResolutionopen => fixed
2016-06-09 15:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/af7f765c5acb0866be95c20196a7a999710ec2d2 [^]
2016-06-09 15:35hgbotCheckin
2016-06-09 15:35hgbotNote Added: 0087121
2016-06-10 09:05marvintmStatusresolved => closed
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087599
2017-11-30 10:09shuehnerFixed in Version => 3.0PR16Q3

Notes
(0087120)
hgbot   
2016-06-09 15:35   
Repository: erp/devel/pi
Changeset: af7f765c5acb0866be95c20196a7a999710ec2d2
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 07 16:57:54 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/af7f765c5acb0866be95c20196a7a999710ec2d2 [^]

Fixed 33126. Creating c_import_entry use Proxy to avoid reading from ad_role

Read to ad_role can be avoided by using Proxy object instead.

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0087121)
hgbot   
2016-06-09 15:35   
Repository: erp/devel/pi
Changeset: 5ea6451d509257da55091173c733ffb5f2f56076
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 09 15:27:20 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5ea6451d509257da55091173c733ffb5f2f56076 [^]

Issue 33126. Improve change by used getProxy variant returning
proper Role.class instance directly instead of a bob and needing to cast it.

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0087599)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test