Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033027
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajoralways2016-05-03 12:352016-05-24 07:51
ReporterJONHMView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR16Q2
StatusclosedFix in branchFixed in SCM revision50cfbabf4fe3
ProjectionnoneETAnoneTarget Version3.0PR16Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR16Q1SCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2016-04-08
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Triggers an Emergency PackNo
Summary

0033027: Cannot export CSV from Widgets

DescriptionAt trying to export CSV from any widget no file is exported nor error window showed
Steps To Reproduce1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Proposed SolutionSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0032838 closedalostale Cannot export CSV from Widgets 

-  Notes
(0086649)
caristu (developer)
2016-05-23 13:36
edited on: 2016-05-23 13:37

 Repository: erp/backports/3.0PR16Q2
Changeset: a08db06ea86f8190fec16c1fa6961331280d5c24
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 23 13:31:02 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/a08db06ea86f8190fec16c1fa6961331280d5c24 [^] [^]

fixes issue 33027: Cannot export CSV from Widgets

  The name of the parameter used to sent the tab ID when exporting to CSV changed, this
  affected a check on DataSourceServlet that was always true when exporting widgets until now.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
(0086691)
alostale (manager)
2016-05-24 07:51

 code reviewed + tested

- Issue History
Date Modified Username Field Change
2016-05-23 13:10 caristu Type defect => backport
2016-05-23 13:10 caristu Target Version => 3.0PR16Q2
2016-05-23 13:11 caristu Assigned To alostale => caristu
2016-05-23 13:36 caristu Note Added: 0086649
2016-05-23 13:36 caristu Status scheduled => resolved
2016-05-23 13:36 caristu Fixed in Version => 3.0PR16Q2
2016-05-23 13:36 caristu Resolution open => fixed
2016-05-23 13:37 caristu Note Edited: 0086649 View Revisions
2016-05-23 13:39 caristu Review Assigned To caristu => alostale
2016-05-24 07:51 alostale Note Added: 0086691
2016-05-24 07:51 alostale Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker